[release] Weekly Patch Release v.1.2.3 [full merge, no squash] #6431

tchaton · 2021-03-09T08:50:30Z

What does this PR do?

The list of commit is described there: #6083

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

… when saved during training (#6073) Co-authored-by: chaton <[email protected]>

* add to docs * update docs * Apply suggestions from code review * Update pytorch_lightning/core/hooks.py Co-authored-by: Rohit Gupta <[email protected]> * nested loaders * Apply suggestions from code review Co-authored-by: Adrian Wälchli <[email protected]> * shorten text length * Update pytorch_lightning/core/hooks.py Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>

codecov · 2021-03-09T08:52:35Z

Codecov Report

Merging #6431 (cdbb898) into release/1.2.x (b3b8f95) will increase coverage by 0%.
The diff coverage is 93%.

@@              Coverage Diff              @@
##           release/1.2.x   #6431   +/-   ##
=============================================
  Coverage             93%     94%           
=============================================
  Files                160     161    +1     
  Lines              11407   11437   +30     
=============================================
+ Hits               10653   10715   +62     
+ Misses               754     722   -32

* Fix when _stable_1d_sort to work when n >= N * Apply suggestions Co-authored-by: Carlos Mocholi <[email protected]>

pep8speaks · 2021-03-09T11:37:01Z

Hello @tchaton! Thanks for updating this PR.

In the file tests/utilities/test_parsing.py:

Line 20:1: E731 do not assign a lambda expression, use a def

Comment last updated at 2021-03-09 16:51:59 UTC

…TPU (#6221) * Fix bug Fix AttributeError: 'NoneType' object has no attribute 'finalize' * Update CHANGELOG.md * deleted a period * Update CHANGELOG.md Co-authored-by: Akihiro Nitta <[email protected]> * Update CHANGELOG.md * Update pytorch_lightning/plugins/training_type/tpu_spawn.py Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>

* resolve bug * update changelog * Update tests/trainer/test_trainer.py * Update pytorch_lightning/profiler/profilers.py Co-authored-by: Jirka Borovec <[email protected]> * resolve comments * resolve flake8 Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

update

…6296) * resolve an issue with TPU * update * add changelog

* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node

* update * resolve bug

* ci: azure reinstall torchtext * move * todos * 0.6.0 * skip examples * formatter * skip * todo * Apply suggestions from code review

* resolve bug * resolve flake8 * revert name

* Call clip gradients if clip val greater than 0 * format * Format * Move to top of file

* patch download * CI * isort * extra remove runif

* adjust versions * release * manifest * pep8 * CI * fix * build

* copy torchtext batch * update * rev * rev

Co-authored-by: Carlos Mocholí <[email protected]>

CHANGELOG.md

Borda

can we get in also this fix #6434

CHANGELOG.md

Borda

there is some mess with commits - I see now 42

update version

carmocca and others added 2 commits March 9, 2021 08:37

Fix ModelPruning(make_pruning_permanent=True) buffers getting removed…

cf9e408

… when saved during training (#6073) Co-authored-by: chaton <[email protected]>

tchaton self-assigned this Mar 9, 2021

tchaton added this to the 1.2.x milestone Mar 9, 2021

Borda mentioned this pull request Mar 9, 2021

Weekly Patch Release v.1.2.3 [full merge, no squash] #6432

Closed

11 tasks

Fix when _stable_1d_sort to work when n >= N (#6177)

5f9bb9d

* Fix when _stable_1d_sort to work when n >= N * Apply suggestions Co-authored-by: Carlos Mocholi <[email protected]>

tchaton force-pushed the v1.2.3 branch from e8be96c to a17a29c Compare March 9, 2021 10:25

chizuchizu and others added 15 commits March 9, 2021 13:57

[bugfix] TPU test hangs to barrier on 1 process (#6272)

96c7f4b

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

resolve tests & update

92c545b

update

[bugfix] TPU + all_gather + SingleTPU shouldn't call xm.all_gather (#…

8578ffa

…6296) * resolve an issue with TPU * update * add changelog

[fix] Ensure we check deepspeed/sharded in multinode DDP (#6297)

3c99bfd

* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node

[bugfix] Check LightningOptimizer doesn't delete optimizer hooks (#6305)

5be327d

* update * resolve bug

hotfix for PT1.6 and torchtext (#6323)

23e12ed

* ci: azure reinstall torchtext * move * todos * 0.6.0 * skip examples * formatter * skip * todo * Apply suggestions from code review

[bugfix] Resolve memory leak for evaluation (#6326)

22348ef

* resolve bug * resolve flake8 * revert name

[Fix] Call clip gradients if clip val greater than 0 (#6330)

d0e7ca3

* Call clip gradients if clip val greater than 0 * format * Format * Move to top of file

CI: fix examples - patch download MNIST (#6357)

48482da

* patch download * CI * isort * extra remove runif

require: adjust versions (#6363)

87c86ce

* adjust versions * release * manifest * pep8 * CI * fix * build

fix importing torchtext batch (#6365)

fa99157

* copy torchtext batch * update * rev * rev

Fix trainer not resetting lightning_optimizers (#6372)

cccf7de

Co-authored-by: Carlos Mocholí <[email protected]>

update python version (#6399)

a57a606

Borda force-pushed the v1.2.3 branch from 28eabd1 to a57a606 Compare March 9, 2021 12:59

kaushikb11 reviewed Mar 9, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Borda approved these changes Mar 9, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

kaushikb11 approved these changes Mar 9, 2021

View reviewed changes

carmocca mentioned this pull request Mar 9, 2021

1.2.x cherries 🍒 #6083

Closed

SeanNaren approved these changes Mar 9, 2021

View reviewed changes

carmocca approved these changes Mar 9, 2021

View reviewed changes

tchaton marked this pull request as ready for review March 9, 2021 13:47

tchaton requested review from ananyahjha93, awaelchli, edenlightning, justusschock, teddykoker and williamFalcon as code owners March 9, 2021 13:47

carmocca suggested changes Mar 9, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

carmocca approved these changes Mar 9, 2021

View reviewed changes

lexierule enabled auto-merge (rebase) March 9, 2021 14:43

Borda requested changes Mar 9, 2021

View reviewed changes

Borda disabled auto-merge March 9, 2021 15:13

Borda force-pushed the v1.2.3 branch from 3e3cdd7 to 4c13e3c Compare March 9, 2021 16:46

v1.2.3 & test past ckpts

cdbb898

update version

Borda force-pushed the v1.2.3 branch from 4c13e3c to cdbb898 Compare March 9, 2021 16:51

Borda approved these changes Mar 9, 2021

View reviewed changes

Borda added Important labels Mar 9, 2021

lexierule merged commit e719d60 into release/1.2.x Mar 9, 2021

lexierule deleted the v1.2.3 branch March 9, 2021 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release] Weekly Patch Release v.1.2.3 [full merge, no squash] #6431

[release] Weekly Patch Release v.1.2.3 [full merge, no squash] #6431

Uh oh!

tchaton commented Mar 9, 2021 •

edited by Borda

Loading

Uh oh!

codecov bot commented Mar 9, 2021 •

edited

Loading

Uh oh!

pep8speaks commented Mar 9, 2021 •

edited

Loading

Uh oh!

Uh oh!

Borda left a comment

Uh oh!

Uh oh!

Uh oh!

Borda left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

[release] Weekly Patch Release v.1.2.3 [full merge, no squash] #6431

[release] Weekly Patch Release v.1.2.3 [full merge, no squash] #6431

Uh oh!

Conversation

tchaton commented Mar 9, 2021 • edited by Borda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Before submitting

PR review

Did you have fun?

Uh oh!

codecov bot commented Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pep8speaks commented Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2021-03-09 16:51:59 UTC

Uh oh!

Uh oh!

Borda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Borda left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

tchaton commented Mar 9, 2021 •

edited by Borda

Loading

codecov bot commented Mar 9, 2021 •

edited

Loading

pep8speaks commented Mar 9, 2021 •

edited

Loading

Borda left a comment •

edited

Loading