-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update docs on arg train_dataloader in fit #6076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lexierule
merged 8 commits into
Lightning-AI:master
from
SkafteNicki:docs_fit_multi_train_loader
Mar 4, 2021
Merged
Update docs on arg train_dataloader in fit #6076
lexierule
merged 8 commits into
Lightning-AI:master
from
SkafteNicki:docs_fit_multi_train_loader
Mar 4, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6076 +/- ##
=======================================
- Coverage 93% 91% -2%
=======================================
Files 160 159 -1
Lines 11402 11365 -37
=======================================
- Hits 10654 10341 -313
- Misses 748 1024 +276 |
Contributor
|
maybe add some examples and update type hints here too: https://github.com/PyTorchLightning/pytorch-lightning/blob/0b271474e5cc35a40009559d6c4488ab3b02723e/pytorch_lightning/core/hooks.py#L386?? |
Borda
approved these changes
Feb 19, 2021
Borda
reviewed
Feb 19, 2021
rohitgr7
approved these changes
Feb 19, 2021
Co-authored-by: Rohit Gupta <[email protected]>
justusschock
approved these changes
Feb 20, 2021
awaelchli
reviewed
Feb 20, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
tchaton
approved these changes
Feb 21, 2021
carmocca
approved these changes
Feb 21, 2021
s-rog
approved these changes
Feb 22, 2021
awaelchli
approved these changes
Mar 2, 2021
Closed
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* add to docs * update docs * Apply suggestions from code review * Update pytorch_lightning/core/hooks.py Co-authored-by: Rohit Gupta <[email protected]> * nested loaders * Apply suggestions from code review Co-authored-by: Adrian Wälchli <[email protected]> * shorten text length * Update pytorch_lightning/core/hooks.py Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Mar 9, 2021
* add to docs * update docs * Apply suggestions from code review * Update pytorch_lightning/core/hooks.py Co-authored-by: Rohit Gupta <[email protected]> * nested loaders * Apply suggestions from code review Co-authored-by: Adrian Wälchli <[email protected]> * shorten text length * Update pytorch_lightning/core/hooks.py Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1959 (comment)
Updates docstring of
fitto mention thattrain_dataloadernow can take in multiple dataloaders.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃