Skip to content

Conversation

@SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Feb 19, 2021

What does this PR do?

Fixes #1959 (comment)
Updates docstring of fit to mention that train_dataloader now can take in multiple dataloaders.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #6076 (f4ce862) into master (0b27147) will decrease coverage by 2%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #6076    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         160     159     -1     
  Lines       11402   11365    -37     
=======================================
- Hits        10654   10341   -313     
- Misses        748    1024   +276     

@rohitgr7
Copy link
Contributor

@Borda Borda enabled auto-merge (squash) February 19, 2021 12:08
@Borda Borda added the ready PRs ready to be merged label Feb 19, 2021
@Borda Borda added the _Will label Feb 22, 2021
@Borda Borda requested a review from awaelchli March 1, 2021 08:09
@lexierule lexierule disabled auto-merge March 4, 2021 19:22
@lexierule lexierule merged commit 4f90455 into Lightning-AI:master Mar 4, 2021
@tchaton tchaton added this to the 1.2.x milestone Mar 8, 2021
@tchaton tchaton mentioned this pull request Mar 8, 2021
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* add to docs

* update docs

* Apply suggestions from code review

* Update pytorch_lightning/core/hooks.py

Co-authored-by: Rohit Gupta <[email protected]>

* nested loaders

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* shorten text length

* Update pytorch_lightning/core/hooks.py

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
lexierule pushed a commit that referenced this pull request Mar 9, 2021
* add to docs

* update docs

* Apply suggestions from code review

* Update pytorch_lightning/core/hooks.py

Co-authored-by: Rohit Gupta <[email protected]>

* nested loaders

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* shorten text length

* Update pytorch_lightning/core/hooks.py

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants