adjust versions #6363
Merged
adjust versions #6363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-06 12:03:00 UTC |
Codecov Report
@@ Coverage Diff @@
## master #6363 +/- ##
========================================
- Coverage 93% 46% -47%
========================================
Files 161 161
Lines 11464 11353 -111
========================================
- Hits 10706 5273 -5433
- Misses 758 6080 +5322 |
Borda
added
3rd party
Borda
requested review from
SeanNaren,
awaelchli,
carmocca,
justusschock,
tchaton and
williamFalcon
as code owners
Borda
requested review from
a team,
SkafteNicki,
jeremyjordan,
kaushikb11,
pl-ghost,
rohitgr7,
s-rog and
yukw777
kaushikb11
reviewed
Mar 6, 2021
| return sorted(options)[-1] | ||
|
|
||
|
|
||
| def main(path_req: str, torch_version: str = None) -> None: |
Contributor
There was a problem hiding this comment.
Suggested change
| def main(path_req: str, torch_version: str = None) -> None: | |
| def main(path_req: str, torch_version: Optional[str] = None) -> None: |
kaushikb11
approved these changes
Mar 6, 2021
carmocca
approved these changes
Mar 6, 2021
| import sys | ||
| from typing import Any, Dict | ||
|
|
||
| VERSIONS_LUT: Dict[str, Dict[str, Any]] = { |
Contributor
There was a problem hiding this comment.
Suggested change
| VERSIONS_LUT: Dict[str, Dict[str, Any]] = { | |
| VERSIONS_LUT: Dict[str, Dict[str, str]] = { |
Contributor
|
whoops, didn't realise auto-merge was enabled and I was the missing reviewer :/ |
Closed
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* adjust versions * release * manifest * pep8 * CI * fix * build
Borda
added a commit
that referenced
this pull request
Mar 9, 2021
* adjust versions * release * manifest * pep8 * CI * fix * build
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* adjust versions * release * manifest * pep8 * CI * fix * build
lexierule
pushed a commit
that referenced
this pull request
Mar 9, 2021
* adjust versions * release * manifest * pep8 * CI * fix * build
This was referenced Mar 12, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃