-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix] Ensure we check deepspeed/sharded in multinode DDP #6297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
approved these changes
Mar 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #6297 +/- ##
=======================================
- Coverage 93% 91% -2%
=======================================
Files 160 160
Lines 11397 11397
=======================================
- Hits 10638 10371 -267
- Misses 759 1026 +267 |
justusschock
approved these changes
Mar 2, 2021
Borda
approved these changes
Mar 2, 2021
Closed
awaelchli
reviewed
Mar 2, 2021
carmocca
approved these changes
Mar 2, 2021
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Mar 2, 2021
…I#6297) * Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node
lexierule
pushed a commit
that referenced
this pull request
Mar 5, 2021
* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node
Borda
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node
lexierule
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode * Add CHANGELOG.md * Add CHANGELOG.md * Drop mock, use actual multi-gpu node
This was referenced Mar 12, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a user bug where when sharded is selected, we hard crash saying to select a support distributed type. Sharded is a valid option, modified the check to use properties defined for future proofing.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃