Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Mar 2, 2021

What does this PR do?

Fix a user bug where when sharded is selected, we hard crash saying to select a support distributed type. Sharded is a valid option, modified the check to use properties defined for future proofing.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added bug Something isn't working distributed Generic distributed-related topic labels Mar 2, 2021
@SeanNaren SeanNaren added this to the 1.2.x milestone Mar 2, 2021
@SeanNaren SeanNaren self-assigned this Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #6297 (298e435) into master (bc577ca) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6297    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         160     160            
  Lines       11397   11397            
=======================================
- Hits        10638   10371   -267     
- Misses        759    1026   +267     

@SeanNaren SeanNaren mentioned this pull request Mar 2, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) March 2, 2021 12:46
@SeanNaren SeanNaren merged commit 8001987 into master Mar 2, 2021
@SeanNaren SeanNaren deleted the fix/multi_node_select branch March 2, 2021 13:36
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Mar 2, 2021
…I#6297)

* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
lexierule pushed a commit that referenced this pull request Mar 5, 2021
* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
Borda pushed a commit that referenced this pull request Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
lexierule pushed a commit that referenced this pull request Mar 9, 2021
* Ensure we check deepspeed/sharded in multinode

* Add CHANGELOG.md

* Add CHANGELOG.md

* Drop mock, use actual multi-gpu node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working distributed Generic distributed-related topic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants