Skip to content

Conversation

@frankier
Copy link
Contributor

@frankier frankier commented Feb 24, 2021

What does this PR do?

Currently if n >= N we will get a "x_pad used before it is defined" type exception.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #6177 (0f558bd) into master (1b498d1) will decrease coverage by 2%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #6177    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         159     159            
  Lines       11380   11361    -19     
=======================================
- Hits        10631   10350   -281     
- Misses        749    1011   +262     

@Borda Borda added this to the 1.2.x milestone Feb 24, 2021
@Borda Borda added bug Something isn't working metrics labels Feb 24, 2021
@Borda Borda requested a review from SkafteNicki February 26, 2021 12:37
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SkafteNicki SkafteNicki added the ready PRs ready to be merged label Feb 26, 2021
@mergify mergify bot requested review from a team February 26, 2021 14:36
@Borda Borda requested a review from carmocca March 1, 2021 08:08
@Borda Borda enabled auto-merge (squash) March 4, 2021 19:09
@Borda Borda merged commit 5d7388d into Lightning-AI:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants