Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

During training, every time the model is saved via ModelCheckpoint, if make_pruning_permanent, the buffers would get removed. This means that the buffers would not accumulate and the pruning amounts are incorrect.

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working priority: 0 High priority task callback labels Feb 19, 2021
@carmocca carmocca added this to the 1.2.x milestone Feb 19, 2021
@carmocca carmocca self-assigned this Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #6073 (faae25c) into master (352e8f0) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #6073   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         159     159           
  Lines       11362   11370    +8     
======================================
- Hits        10605   10581   -24     
- Misses        757     789   +32     

@carmocca carmocca mentioned this pull request Feb 19, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Base automatically changed from add-checkpoint-to-callback-on_save_checkpoint to master February 25, 2021 15:48
@carmocca carmocca changed the title [Blocked by #6072] Fix ModelPruning(make_pruning_permanent=True) buffers getting removed when saved during training Fix ModelPruning(make_pruning_permanent=True) buffers getting removed when saved during training Feb 25, 2021
@mergify mergify bot removed the has conflicts label Feb 25, 2021
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smaller comments

@carmocca carmocca added the ready PRs ready to be merged label Mar 1, 2021
@mergify mergify bot added the has conflicts label Mar 1, 2021
@mergify mergify bot removed the has conflicts label Mar 1, 2021
@carmocca carmocca enabled auto-merge (squash) March 2, 2021 13:23
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 4a8422c into master Mar 3, 2021
@carmocca carmocca deleted the pruning-modelcheckpoint-hotfix branch March 3, 2021 12:29
tchaton added a commit that referenced this pull request Mar 9, 2021
lexierule pushed a commit that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working callback priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants