-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix ModelPruning(make_pruning_permanent=True) buffers getting removed when saved during training #6073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6073 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 159 159
Lines 11362 11370 +8
======================================
- Hits 10605 10581 -24
- Misses 757 789 +32 |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Co-authored-by: chaton <[email protected]>
SkafteNicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smaller comments
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
… when saved during training (#6073) Co-authored-by: chaton <[email protected]>
… when saved during training (#6073) Co-authored-by: chaton <[email protected]>
What does this PR do?
During training, every time the model is saved via
ModelCheckpoint, ifmake_pruning_permanent, the buffers would get removed. This means that the buffers would not accumulate and the pruning amounts are incorrect.Before submitting
PR review