[bugfix] TPU test hangs to barrier on 1 process #6272

tchaton · 2021-03-01T19:32:46Z

What does this PR do?

This PR resolves a bug with TPU.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

…torch-lightning into tpu_fix_test

codecov · 2021-03-01T19:34:56Z

Codecov Report

Merging #6272 (6f3a72f) into master (bc577ca) will decrease coverage by 4%.
The diff coverage is 75%.

@@           Coverage Diff           @@
##           master   #6272    +/-   ##
=======================================
- Coverage      93%     90%    -4%     
=======================================
  Files         160     160            
  Lines       11397   11526   +129     
=======================================
- Hits        10638   10347   -291     
- Misses        759    1179   +420

pytorch_lightning/trainer/trainer.py

pytorch_lightning/plugins/training_type/tpu_spawn.py

tests/models/test_tpu.py

pytorch_lightning/plugins/training_type/tpu_spawn.py

Borda · 2021-03-02T22:17:58Z

pytorch_lightning/plugins/training_type/tpu_spawn.py

                self.mp_queue.put(last_path)
                self.mp_queue.put(results)

+    def save(self, state_dict: Dict, path: str) -> None:


shall this be rather protected?

Suggested change

def save(self, state_dict: Dict, path: str) -> None:

def _save(self, state_dict: Dict, path: str) -> None:

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

Your Name and others added 5 commits March 1, 2021 19:18

update

e9becd4

resolve flake8

69be46c

update

eb7a762

Merge branch 'tpu_fix_test' of https://github.com/PyTorchLightning/py…

5e4eb2c

…torch-lightning into tpu_fix_test

update

f98008f

tchaton requested review from Borda, SeanNaren, awaelchli, carmocca, justusschock and williamFalcon as code owners March 1, 2021 19:32

tchaton added this to the 1.2.x milestone Mar 1, 2021

tchaton self-assigned this Mar 1, 2021

tchaton added the accelerator: tpu Tensor Processing Unit label Mar 1, 2021

update changelog

cf2833d

awaelchli reviewed Mar 1, 2021

View reviewed changes

pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved

Borda reviewed Mar 1, 2021

View reviewed changes

pytorch_lightning/plugins/training_type/tpu_spawn.py Outdated Show resolved Hide resolved

zcain117 reviewed Mar 1, 2021

View reviewed changes

tests/models/test_tpu.py Show resolved Hide resolved

update

b49dced

awaelchli approved these changes Mar 2, 2021

View reviewed changes

resolve flake8

7df3aae

mergify bot added the has conflicts label Mar 2, 2021

Merge branch 'master' into tpu_fix_test

a2087c8

tchaton enabled auto-merge (squash) March 2, 2021 10:39

mergify bot removed the has conflicts label Mar 2, 2021

SeanNaren approved these changes Mar 2, 2021

View reviewed changes

carmocca reviewed Mar 2, 2021

View reviewed changes

pytorch_lightning/plugins/training_type/tpu_spawn.py Outdated Show resolved Hide resolved

Update pytorch_lightning/plugins/training_type/tpu_spawn.py

6f3a72f

carmocca approved these changes Mar 2, 2021

View reviewed changes

carmocca added ready PRs ready to be merged bug Something isn't working labels Mar 2, 2021

carmocca mentioned this pull request Mar 2, 2021

1.2.x cherries 🍒 #6083

Closed

tchaton added the _Will label Mar 2, 2021

tchaton mentioned this pull request Mar 2, 2021

Kaggle and TPUs - Errors popping randomly in and out of existence #5665

Closed

Borda approved these changes Mar 2, 2021

View reviewed changes

williamFalcon approved these changes Mar 2, 2021

View reviewed changes

tchaton merged commit 1aac481 into master Mar 2, 2021

tchaton deleted the tpu_fix_test branch March 2, 2021 23:01

tchaton added a commit that referenced this pull request Mar 9, 2021

[bugfix] TPU test hangs to barrier on 1 process (#6272)

c388431

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

Borda pushed a commit that referenced this pull request Mar 9, 2021

[bugfix] TPU test hangs to barrier on 1 process (#6272)

96c7f4b

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

tchaton added a commit that referenced this pull request Mar 9, 2021

[bugfix] TPU test hangs to barrier on 1 process (#6272)

81cb634

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

tchaton added a commit that referenced this pull request Mar 9, 2021

[bugfix] TPU test hangs to barrier on 1 process (#6272)

6918465

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

lexierule pushed a commit that referenced this pull request Mar 9, 2021

[bugfix] TPU test hangs to barrier on 1 process (#6272)

9fac060

* update * resolve flake8 * update * update * update changelog * update * resolve flake8 Co-authored-by: Your Name <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[bugfix] TPU test hangs to barrier on 1 process #6272

[bugfix] TPU test hangs to barrier on 1 process #6272

Uh oh!

tchaton commented Mar 1, 2021 •

edited by Borda

Loading

Uh oh!

codecov bot commented Mar 1, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Borda Mar 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	def save(self, state_dict: Dict, path: str) -> None:
	def _save(self, state_dict: Dict, path: str) -> None:

[bugfix] TPU test hangs to barrier on 1 process #6272

[bugfix] TPU test hangs to barrier on 1 process #6272

Uh oh!

Conversation

tchaton commented Mar 1, 2021 • edited by Borda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Before submitting

PR review

Did you have fun?

Uh oh!

codecov bot commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Borda Mar 2, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tchaton commented Mar 1, 2021 •

edited by Borda

Loading

codecov bot commented Mar 1, 2021 •

edited

Loading