-
Notifications
You must be signed in to change notification settings - Fork 3.6k
update python version in XLA installation in Google Colab notebook #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #6399 +/- ##
=======================================
- Coverage 94% 92% -2%
=======================================
Files 161 161
Lines 11476 11476
=======================================
- Hits 10735 10511 -224
- Misses 741 965 +224 |
| }, | ||
| "source": [ | ||
| "! pip install cloud-tpu-client==0.10 https://storage.googleapis.com/tpu-pytorch/wheels/torch_xla-1.7-cp36-cp36m-linux_x86_64.whl" | ||
| "! pip install cloud-tpu-client==0.10 https://storage.googleapis.com/tpu-pytorch/wheels/torch_xla-1.7-cp37-cp37m-linux_x86_64.whl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any documentation we should add to handle future version changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just follow Google announcement on Colab upgrades....
Unfortunately there is no simple way to test colab in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the docs we show these commands here:
https://pytorch-lightning.readthedocs.io/en/latest/advanced/tpu.html#colab-tpus
maybe this is more future proof, and we should include them in the notebooks?
I have totally no clue here, found this fix randomly and only did this because on call tbh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@awaelchli eventually you can also drop py 3.6 from testing matrix in our CI |
What does this PR do?
Fixes #6382
Everytime something changes in Google Colab you have to go here and manually update the numbers, duh :(
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃