[bugfix] TPU + all_gather + SingleTPU shouldn't call xm.all_gather #6296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
SeanNaren,
awaelchli,
justusschock and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6296 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 160 160
Lines 11397 11399 +2
======================================
- Hits 10638 10609 -29
- Misses 759 790 +31 |
SeanNaren
reviewed
Mar 2, 2021
Comment on lines
+49
to
+52
| # todo: Add support for backward with all_gather | ||
| if torch.distributed.is_initialized(): | ||
| return xm.all_gather(tensor, group=group, sync_grads=sync_grads) | ||
| return tensor |
Contributor
There was a problem hiding this comment.
Code cov complaining about no test, probably want to add one to make sure this case is covered in single TPU!
Contributor
Author
There was a problem hiding this comment.
The test updates cover this part but coverage is currently not supported for TPU.
carmocca
reviewed
Mar 2, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
Borda
approved these changes
Mar 2, 2021
Collaborator
|
can we add a test for it? |
carmocca
approved these changes
Mar 3, 2021
SeanNaren
approved these changes
Mar 3, 2021
Closed
tchaton
added a commit
that referenced
this pull request
Mar 9, 2021
…6296) * resolve an issue with TPU * update * add changelog
Borda
pushed a commit
that referenced
this pull request
Mar 9, 2021
…6296) * resolve an issue with TPU * update * add changelog
tchaton
added a commit
that referenced
this pull request
Mar 9, 2021
…6296) * resolve an issue with TPU * update * add changelog
tchaton
added a commit
that referenced
this pull request
Mar 9, 2021
…6296) * resolve an issue with TPU * update * add changelog
lexierule
pushed a commit
that referenced
this pull request
Mar 9, 2021
…6296) * resolve an issue with TPU * update * add changelog
This was referenced Mar 12, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃