[Fix] Call clip gradients if clip val greater than 0 #6330
Merged
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
requested review from
Borda,
awaelchli,
carmocca,
justusschock,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6330 +/- ##
======================================
Coverage 93% 93%
======================================
Files 160 160
Lines 11304 11304
======================================
Hits 10531 10531
Misses 773 773 |
carmocca
approved these changes
Mar 3, 2021
ananthsub
approved these changes
Mar 4, 2021
awaelchli
approved these changes
Mar 4, 2021
tests/plugins/test_sharded_plugin.py
Outdated
Comment on lines
285
to
288
| if clip_val > 0: | ||
| mock_oss_clip_grad_norm.assert_called() | ||
| else: | ||
| mock_oss_clip_grad_norm.assert_not_called() |
Contributor
There was a problem hiding this comment.
nice usage of mock! love it
SeanNaren
added
ready
Closed
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Call clip gradients if clip val greater than 0 * format * Format * Move to top of file
Borda
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Call clip gradients if clip val greater than 0 * format * Format * Move to top of file
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Call clip gradients if clip val greater than 0 * format * Format * Move to top of file
tchaton
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Call clip gradients if clip val greater than 0 * format * Format * Move to top of file
lexierule
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Call clip gradients if clip val greater than 0 * format * Format * Move to top of file
This was referenced Mar 13, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6322
It seems somewhere along the line we lost the guard to ensure we only clip gradients when greater than 0. Add a test to make sure we don't do so in the future.
cc @mees
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃