Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Mar 3, 2021

What does this PR do?

This PR delete self.trainer.evaluation_loop.outputs on validation_epoch_end call.

Fixes #5735

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Mar 3, 2021
@tchaton tchaton added this to the 1.2.x milestone Mar 3, 2021
@tchaton tchaton self-assigned this Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #6326 (e2d179d) into master (49c579f) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #6326   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         160     160           
  Lines       11415   11416    +1     
======================================
+ Hits        10644   10645    +1     
  Misses        771     771           

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the logging_ directory name as that's done on purpose to not collide with the stdlib logging

@tchaton tchaton enabled auto-merge (squash) March 3, 2021 17:11
@tchaton tchaton requested a review from carmocca March 3, 2021 17:11
@tchaton tchaton merged commit 46540ee into master Mar 5, 2021
@tchaton tchaton deleted the bugfix/5735_memory_leak branch March 5, 2021 07:52
@tchaton tchaton mentioned this pull request Mar 8, 2021
tchaton added a commit that referenced this pull request Mar 9, 2021
* resolve bug

* resolve flake8

* revert name
Borda pushed a commit that referenced this pull request Mar 9, 2021
* resolve bug

* resolve flake8

* revert name
tchaton added a commit that referenced this pull request Mar 9, 2021
* resolve bug

* resolve flake8

* revert name
lexierule pushed a commit that referenced this pull request Mar 9, 2021
* resolve bug

* resolve flake8

* revert name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bounded memory leak caused by trainer.evalutaion_loop.outputs

4 participants