Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 5, 2021

What does this PR do?

Resolves #6323 with pytorch/vision#1938 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added example ci Continuous Integration 3rd party Related to a 3rd-party labels Mar 5, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 5, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-05 16:26:22 UTC

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #6357 (a4cdf68) into master (46540ee) will increase coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6357    +/-   ##
=======================================
+ Coverage      91%     93%    +2%     
=======================================
  Files         161     161            
  Lines       11457   11457            
=======================================
+ Hits        10481   10692   +211     
+ Misses        976     765   -211     

@Borda Borda marked this pull request as ready for review March 5, 2021 11:03
@Borda Borda changed the title CI: fix examples - MNIST CI: fix examples - patch download MNIST Mar 5, 2021
@Borda Borda enabled auto-merge (squash) March 5, 2021 11:26
Borda and others added 2 commits March 5, 2021 14:34
Co-authored-by: Carlos Mocholí <[email protected]>
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit e848542 into master Mar 5, 2021
@Borda Borda deleted the ci/examples branch March 5, 2021 16:50
@tchaton tchaton mentioned this pull request Mar 8, 2021
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* patch download

* CI

* isort

* extra
Borda added a commit that referenced this pull request Mar 9, 2021
* patch download

* CI

* isort

* extra

remove runif
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* patch download

* CI

* isort

* extra
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* patch download

* CI

* isort

* extra

remove runif
lexierule pushed a commit that referenced this pull request Mar 9, 2021
* patch download

* CI

* isort

* extra

remove runif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party Related to a 3rd-party ci Continuous Integration example

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants