chore: release 1.0.0-rc.9 #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: refactor cookie API M2-331 reduce code duplication refactor: remove unneeded type assertion refactor: refactor cookies to use the new cookie API refactor: checkpoint refactor: i18n plugin refactor: improve typings LocaleObject[] | string[] unions refactor: i18n plugin refactor: refactor middleware to typescript update cookies aswell refactor: don't return void refactor: use storefront ui colors for UiNotification refactor: more cookie refactors refactor: refactor i18n plugin refactor: fix unit tests post-refactor * refactor: add remove method add optional opts * refactor: add proper typing for nuxtplugin + integration * refactor: add remove method to state * refactor: use new remove methods where applicable * refactor: re-add getters and simplify i18n ternary
* ci: simplify env config BREAKING: rename certain env vars MAGENTO_GRAPHQL -> MAGENTO_GRAPHQL_URL REDIS__* (HOST etc.) -> REDIS_* MAGENTO_EXTERNAL_CHECKOUT -> MAGENTO_EXTERNAL_CHECKOUT_ENABLED _ENABLED env vars will only enable things if you set their value to "true" (MY_ENV_VAR=true) remove convict and related format package because convict cannot be used in a browser - BREAKING: use .env in packages/theme instead of packages/theme/config/[env].json remove dotenv because nuxt already uses dotenv under the hood stop using GitHub repository secrets that are not actually secrets refactor: remove convict and dotenv dotenv is already used by nuxt under the hood remove leftover config import add sentry_dsn to dockerfile args * ci!: add VSF_ prefix to environment variables add VSF_ prefix where omitted
removes the warning when running yarn dev:theme
there's no point in having 3 .lintstagedrc files that all do the same thing this commit also fixes the issue where comitting ANY file that is not in packages/**/* would crash the precommit hook and abort git commit this was happening (Configuration not found error) because there was no .lintstagedrc file in the repo root, so `npx lint-staged` did not know what to do
with key prefixes, this is so that redis does not contain thousands of super old keys for old deployments forever M2-342
* chore: add graphql peer dependency restore newer graphql version * chore: add vue as hard dependency this gives us direct control over the vue version rather than relying on whatever a subdependency installs * chore: fix eslint-config-typescript not in internal eslint pkg * chore: fix @nuxt/typescript-build conflict between 'latest' & '2.1.0'
- move category filters to the separate component - add filters renderers and filter config resolver - move configuration from middleware to catalog module - partially add UT, add todo for missing tests
* refactor: refactored useCategory for better dx experience * Update packages/theme/composables/useCategory/index.ts Co-authored-by: Artur Tagisow <[email protected]> * refactor. refactored useCategory errors object to use load instead of search Co-authored-by: Artur Tagisow <[email protected]>
* feat(catalog): breadcrumbs feat(catalog): breadcrumbs refactor: make CategoryTree use common logic refactor: add props to breadcrumbs refactor: destructure ancestors refactor: fix isCategoryTreeLoaded conditions refactor: move breadcrumbs outside categories refactor: use app.localePath instead of cookies chore: comments refactor: destructure context for app * fix: store cookie not set during first page load This was tested after clearing all the cookies in the browser
…related API methods (#821) * chore: change useAddress to a function declaration * feat: add useAddress jsdocs * docs: add jsdoc comments to useAddress * docs: add JSDoc comments to customer address API methods * docs: add JSDoc comments to the interfaces used by useAddresses * fix: rollback a miss replace * fix: fix useAddress methods' examples * docs: fix list formatting in useAddresses * docs: list useAddresses and the related API methods in documentation * docs: explain in useAddresses were the addresses can be used * docs: remove list of places that use useAddresses * docs: break line between section directive and content
…ods using TSDocs (#828) * chore: transform categoryList API method into function declaration * docs: add TSDocs to categoryList API method and its GraphQL Query * chore: standardize useCategory and its types * docs: add TSDocs to useCategory and its types * docs: change how types are exported to fix TSDoc links * fix: fix categoryList item in the API Methods menu in the docs * fix: use Category type instead of any in useCategory Co-authored-by: Marcin Kwiatkowski <[email protected]>
…sidebar (#830) * refactor(filter): rework filters - move category filters to the separate component - add filters renderers and filter config resolver - move configuration from middleware to catalog module - partially add UT, add todo for missing tests * refactor(filters): add selected filters component M2-406 * refactor: update category page after merge develop * refactor: on filters/sorting/pagination change only products will be reloaded
- fix env typo
…useCategorySearch` composable (#848) * feat!: rename UseCategorySearch type to UseCategorySearchInterface * chore: transform categorySearch to function declaration * docs: add docs for categorySearch API method * chore: convert useCategorySearch to function declaration * feat: export useCategorySeach types and improve its definitions * docs: add docs for useCategorySearch composable * feat!: make error, loading and result readonly in useCategorySearch * docs: improve useCategorySearch description * feat!: rename the errors interface of useCategory to UseCategorySearchErrors * feat: export useCategorySearch types
* refactor: remove cookie instead of empty set test: fix tests * refactor: move graphqlclient from useApi to context M2-354 this is so you can query graphql endpoints in plugins refactor: useApi to use client from context refactor: move dynamic headers to client instance I don't want to keep the append the headers in useApi because if someone wants to pull the graphql clients from the context - e.g. when requesting something in a plugin - they'll have to reimplement the cookie logic again this commit is a checkpoint commit - the '' fallback in graphqlClient isn't ideal because the header shouldn't be appended to the request if it's empty. Getters are limited int this way. I'll try something with Proxy refactor: proxy workaround for dynamic headers refactor: use proxies as workaround for dynamic headers refactor: add template types to useApi refactor: remove references to customApolloHttpLinkOptions fix: fix spread refactor: code review changes
… useBilling composable (#844) * chore: transform useBilling to a function declaration * feat: add types and interfaces for useBilling * docs: add TSDoc comments to useBilling and its types * feat!: make useBilling error and loading refs readonly * feat!: define an interface for billingDetails in useBilling save method * docs: remove the "remarks" section in useBilling * docs: list useBilling in docs' composables menu * docs: remove placement in loading ref * docs: fix useBilling load params arg that shouldn't be require
- add nuxt-img support on cart and product page - fix images proportions in all places where nuxt-img is used
…Order` composable (#845) * feat!: make `loading` and `error` properties readonly in the `useUserOrder` composable * docs: add JSDoc to the `customerOrders` API handler
M2-496 vuejs/pinia#981 fix: ts errors because of now enabled noImplicitAny: true
M2-496 `this.$nuxt` is only valid when using tsserver (TypeSCript language server), but not with Volar. Volar is for Vue 3 by default while for Vue 2 some extra config is needed, so that's probably why
* test: get categorysidebar tests to run in minimal way * test: fix CouponCode crashing because of missing useCart * test: add pricing information to useCart mock this is so CartSidebar can calculate and display totals correctly * test: make old, skipped, CartSidebar tests work * test: add checkout redirect test * test: add draft for quantity test no idea why doesn't it work - one of the products is in stock * test: add remove item from cart test draft * test: fix quantity test * test: add configurable product tests * test: add bundle products * test: update subtotal
* refactor: refactor use api - add graphql-tag - remove count from filters * refactor: useApi - update unit tests
github-actions
bot
requested review from
Frodigo,
bartoszherba and
sethidden
as code owners
added 2 commits
June 10, 2022 08:57
Frodigo
force-pushed
the
release/1.0.0-rc.9
branch
2 times, most recently
from
c25a47a to
645bb20
Compare
Frodigo
force-pushed
the
release/1.0.0-rc.9
branch
from
645bb20 to
e62ac09
Compare
Frodigo
force-pushed
the
release/1.0.0-rc.9
branch
from
3bbe9f5 to
db439d2
Compare
Frodigo
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue Storefront for Magento 1.0.0-rc.9 highlights
New features
Bugfix
Refactors
Tests
Chore
Documentation