refactor: make unit tests typing work even when theme is moved to template-magento #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
force-pushed
the
M2-639-unit-testing-not-working-when-theme-in-template
branch
from
09b0494 to
bf4dd55
Compare
bartoszherba
approved these changes
Jun 2, 2022
Frodigo
approved these changes
Jun 2, 2022
Frodigo
deleted the
M2-639-unit-testing-not-working-when-theme-in-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types should be taken from local theme node_modules if they contain anything (template-magento), but in the regular case in the magento2 repo it should take types from the repo root, since yarn workspaces put all packages in the repo root
this pr aligns magento2, while vuestorefront/template-magento#24 aligns template-magento. Marcin is aware that this may cause conflicts etc.