This repository was archived by the owner on Feb 13, 2023. It is now read-only.
fix: unit tests not working #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit was made because after moving the whole repo from packages/theme to the template-magento repo unit tests stopped working this is because all packages in magento2 repo are in the repo root's node_modules, so packages/theme doesn't contain them normally. this changes in the context of template-magento also reverted some changes made during the rc7 release which attempted to fix the issue
Frodigo
approved these changes
Jun 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit was made because after moving the whole repo from packages/theme to
the template-magento repo unit tests stopped working
this is because all packages in magento2 repo are in the repo root's
node_modules, so packages/theme doesn't contain them normally. this changes in
the context of template-magento
also reverted some changes made during the rc7 release which attempted to fix
the issue
this pr aligns template-magento, whereas #24 aligns magento2 repo