fix: disable body scroll lock #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see SfSidebar's body scroll lock doesn't really lock the scrolling on mobile M2-571
packages/theme/modules/catalog/category/components/filters/CategoryFilters.vue
Outdated
Show resolved
Hide resolved
packages/theme/modules/catalog/category/components/filters/CategoryFilters.vue
Show resolved
Hide resolved
bartoszherba
previously approved these changes
May 25, 2022
Frodigo
suggested changes
May 26, 2022
packages/theme/modules/catalog/category/components/filters/CategoryFilters.vue
Outdated
Show resolved
Hide resolved
sethidden
force-pushed
the
M2-571-scrolling-fix-second-attempt
branch
from
1ff553c to
5a49847
Compare
bartoszherba
approved these changes
May 26, 2022
Frodigo
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR got back from QA as not fixing the issue. Have to use the uglier workaround - SfSidebar doesn't block scrolling anyway (double scrollbars on stage in filter sidebar), so I'm not worried about disabling the body scroll lock globally.