fix!: search bar not returning results #1087
Conversation
| @SearchBar:toggle="isSearchOpen = $event" | ||
| @SearchBar:result="result = $event" | ||
| :is-search-open="isSearchOpen" | ||
| @set-is-open="isSearchOpen = $event" |
There was a problem hiding this comment.
this wasn't a toggle per se, it always set the emitted value
to be a toggle, it'd have to be "isSearchOpen = !isSearchOpen"
| }, | ||
| directives: { clickOutside }, | ||
| props: { | ||
| isSearchOpen: { |
There was a problem hiding this comment.
remove isSearchOpen ref from SearchBar itself as it was duplicated.
There's was isSearchOpen in AppHeader.vue that's necessary for both SearchBar and SearchResults, so there's no point keeping a duplicate of the same ref inside SearchBar - they could desync somehow etc.
So 2 way binding is used here now
| }, | ||
| }, | ||
| setup({ itemsPerPage, minTermLen }, { emit }) { | ||
| setup(props, { emit }) { |
There was a problem hiding this comment.
don't destructure props because of reactivity loss
| const closeSearch = (event: MouseEvent) => { | ||
| if (document) { | ||
| const searchResultsEl = document.querySelectorAll('.search'); | ||
| const searchResultsEl = document.querySelector('.search'); |
There was a problem hiding this comment.
No point searching for all instances of .search if you only check the first element in the array below
This will be removed later since communicating thorugh document. isn't the best
sethidden
force-pushed
the
M2-672-and-M2-700-search-bar-doesnt-work-plus-typing
branch
from
6ffff3c to
5e22ace
Compare
useFacet is meant to be used with url sorting params in the product category page, not with simple product searches. useFacet implicitly has some category search logic while the search bar doesn't care about products
| const productList : Products = await getProductList({ | ||
| pageSize: props.itemsPerPage, | ||
| search: term.value, | ||
| }) as unknown as Products; |
There was a problem hiding this comment.
Have to override type because getProductList returns some "ProductListQUERY" type instead of something that contains ProductInterface
Frodigo
changed the title
sethidden
force-pushed
the
M2-672-and-M2-700-search-bar-doesnt-work-plus-typing
branch
from
5e22ace to
367efb9
Compare
the wishlist store initially downloads only product counts. the actual products are loaded later on demand, because that's a slow request. the problem is if you search the wishlist while the actual wishlist products aren't loaded yet, every search result will appear as if it's not in the wishlist (heart icon instead of heart_fill)
sethidden
force-pushed
the
M2-672-and-M2-700-search-bar-doesnt-work-plus-typing
branch
from
367efb9 to
b863587
Compare
sethidden
deleted the
M2-672-and-M2-700-search-bar-doesnt-work-plus-typing
branch
useFacet is meant to be used with url sorting params in the product category
page, not with simple product searches. useFacet implicitly has some category
search logic while the search bar doesn't care about categories
follow-up to #1075