Skip to content

Conversation

@Frodigo
Copy link
Contributor

@Frodigo Frodigo commented Jun 6, 2022

Description

Added product skeleton instead of the loader to fix layout shift issue on the product page.

Motivation and Context

Improving performance and UX.

How Has This Been Tested?

tested on my local, using network throttling on various types of products.

Screenshots (if appropriate):

Screenshot 2022-06-06 at 08 32 02

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo added this to the 1.0.0-rc.9 milestone Jun 6, 2022
@Frodigo Frodigo merged commit 286e2f0 into develop Jun 7, 2022
@Frodigo Frodigo deleted the fix/M2-738-layout-shift-on-pdp branch June 7, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants