Skip to content

refactor: connection to api refactor #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2022
Merged

refactor: connection to api refactor #1101

merged 1 commit into from
Jun 9, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 7, 2022 •
edited
Loading

Description

  • add init function for a persistent GraphQl client creation

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba
feat: adr-004-connection-to-api
4e59b4b 
- add init function for a persisten grapjhql client creation
@bartoszherba bartoszherba marked this pull request as draft June 7, 2022 13:31
@bartoszherba bartoszherba marked this pull request as ready for review June 8, 2022 06:24
sethidden
sethidden approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@sethidden sethidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming it's not possible to pass the getHeaders in some global interceptor instead of manually passing them in

@bartoszherba bartoszherba changed the title feat: adr-004-connection-to-api feat: adr004 connection to api refactor Jun 9, 2022
@bartoszherba bartoszherba merged commit 020b641 into develop Jun 9, 2022
@bartoszherba bartoszherba deleted the adr-004-connection-to-api branch June 9, 2022 06:47
@Frodigo Frodigo added this to the 1.0.0-rc.9 milestone Jun 9, 2022
@Frodigo Frodigo changed the title feat: adr004 connection to api refactor refactor: connection to api refactor Jun 10, 2022
@Frodigo Frodigo mentioned this pull request Jun 10, 2022
Merged
@Frodigo Frodigo mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethidden sethidden sethidden approved these changes

@Frodigo Frodigo Awaiting requested review from Frodigo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.9

Development

Successfully merging this pull request may close these issues.

4 participants

@bartoszherba @sethidden @Frodigo