refactor: use null instead of {} #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
force-pushed
the
M2-643-use-null-instead-of-object-literal
branch
2 times, most recently
from
660eac9 to
1811c57
Compare
sethidden
commented
May 27, 2022
| @@ -0,0 +1,55 @@ | |||
| import type { CustomerAddress, CartAddressInterface } from '~/modules/GraphQL/types'; | |||
Contributor
Author
There was a problem hiding this comment.
(file was moved from address.js)
Contributor
There was a problem hiding this comment.
Maybe the file should be located in modules/checkout/helpers?
Contributor
Author
There was a problem hiding this comment.
I'm just changing the extension :P
sethidden
commented
May 27, 2022
| telephone: string; | ||
| } | ||
|
|
||
| export const getInitialCheckoutAddressForm = () : CheckoutAddressForm => ({ |
Contributor
Author
There was a problem hiding this comment.
Thanks to this, the {} can be avoided
sethidden
force-pushed
the
M2-643-use-null-instead-of-object-literal
branch
from
1811c57 to
7b5929e
Compare
sethidden
commented
May 27, 2022
| export const getConfiguredVariant = (product: ConfigurableCartItem): ProductInterface | null => product?.configured_variant || null; | ||
|
|
||
| // eslint-disable-next-line import/no-named-as-default-member | ||
| export const getFormattedPrice = (price: number) => getFormattedPrice(price); |
Contributor
Author
There was a problem hiding this comment.
removed weird self-referencing getter. it's not used anywhere
Frodigo
previously approved these changes
May 27, 2022
| @@ -0,0 +1,55 @@ | |||
| import type { CustomerAddress, CartAddressInterface } from '~/modules/GraphQL/types'; | |||
Contributor
There was a problem hiding this comment.
Maybe the file should be located in modules/checkout/helpers?
sethidden
force-pushed
the
M2-643-use-null-instead-of-object-literal
branch
from
7b5929e to
415ab27
Compare
Frodigo
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Checkout.vue and Billing.vue there was a case where
getSomeData() || {}was used. This was probably done to avoid worrying if something is null or not and avoiding the "x is null, trying to access property abc" error.The problem with that is that it also causes problems with typing, as you'd get errors like "X is not assignable to {}"