refactor: add interface for useProductsWithCommonCardProps #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
previously approved these changes
Jun 1, 2022
This commit was made because in CategoryProductPrice.vue there's was an incident of ugly type drilling like "ReturnType<typeof useProductsWithCommonCardProps>["property"][number]" M2-646
sethidden
force-pushed
the
M2-646-add-common-card-props-interface
branch
from
a6a4a31 to
88dd5a2
Compare
bartoszherba
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove temporary workaround in CategoryProductPrice.vue