Skip to content

feat: add configurable filters #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

feat: add configurable filters #1060

merged 1 commit into from
May 26, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented May 25, 2022 •
edited
Loading

Description

  • filters can now be whitelisted
  • update how yes_no filter is rendered on the applied filrer list
  • update types for removable filters
  • add docs for the filters managing

Motivation and Context

Improvement

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2022-05-25 at 09 26 13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the M2-625-configure-category-page branch from ee01961 to b1e580e Compare May 25, 2022 08:11
@Frodigo Frodigo added this to the 1.0.0-rc.8 milestone May 26, 2022
Frodigo
Frodigo previously approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@Frodigo Frodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only console.log to remove.

@bartoszherba bartoszherba force-pushed the M2-625-configure-category-page branch from b1e580e to 6cbc146 Compare May 26, 2022 06:05
@bartoszherba
feat: add configurable filters
cb4eac4 
- filters can now be whitelisted
- update how yes_no filter is rendered on the applied filrer list
- update types for removable filters
- add docs for the filters managing
@bartoszherba bartoszherba force-pushed the M2-625-configure-category-page branch from 6cbc146 to cb4eac4 Compare May 26, 2022 06:38
@bartoszherba bartoszherba requested a review from Frodigo May 26, 2022 06:54
@Frodigo Frodigo modified the milestones: 1.0.0-rc.8, 1.0.0-rc.9 May 26, 2022
@bartoszherba bartoszherba merged commit 029000c into develop May 26, 2022
@bartoszherba bartoszherba deleted the M2-625-configure-category-page branch May 26, 2022 12:27
@Frodigo Frodigo mentioned this pull request Jun 10, 2022
Merged
@Frodigo Frodigo mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethidden sethidden Awaiting requested review from sethidden

1 more reviewer

@Frodigo Frodigo Frodigo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.9

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszherba @Frodigo