-
Notifications
You must be signed in to change notification settings - Fork 2.4k
✨ New Profiles #3115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
✨ New Profiles #3115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit d3d125f failed. |
4 tasks
Extracted menu to it's own component so that it can be used in both ShowcaseCard and FeaturedSandbox
Contributor
|
I added my remarks in a notion document |
* Put templates under 1 item * Upgrade dependencies * Fix weird apollo caching bug * Fix type error * Remove need for teamId in unmakeTemplates * Fix cache update function
* refactored sandbox page to overmind * fix changing sandbox
* change some zindexes around * add privacy toggle * adjust for subscripiton * doh! undefined check. where is your typescript now * Fix typing of as * only show privacy toggle if the user is owner * not just subscription but also user
This reverts commit 19688a5.
* fix text overflow in dashboard * show ellipses * remove unsued prop
* remove duplicate decorator * add parent styles to layout decorator * add min height to layout decorator * add common base element * use base element for other components * add all fontsizes + update example
* remove duplicate decorator * add parent styles to layout decorator * add min height to layout decorator * add common base element * use base element for other components * add all fontsizes + update example * add Text, mutedForeground token
* add input * small fixes * only show invisible label if no label
* use text inside collapsible * use size instead of absolute ✨ * prefer element method
* Add noindex to search page Landing on search page results from a Google search is a poor experience, and Google is struggling to crawl the search pages properly resulting in some weird search results. This change prevents Google from indexing and crawling this page. * Update index.tsx
* start textarea * fix counter * update input to use text component * remove invisible label * small fixes * Update packages/components/src/components/Textarea/index.tsx Co-Authored-By: Siddharth Kshetrapal <[email protected]> * update styles * replace css with style * get right input * add type * fix ts * clran up types * fix padding * add --exit-zero-on-changes * Update package.json Co-authored-by: Siddharth Kshetrapal <[email protected]>
* add theme provider * add box sizing for storybook Co-authored-by: Sara Vieira <[email protected]>
* add select component * move svg to varuable * add hover * add icon * use currentcolor * remove disabled
* add more tests cases * use token instead of color
* autosize for textarea * forgot to remove props
🚧 Progress Commit
* button wip * write up link + danger * ts ignores Co-authored-by: Sara Vieira <[email protected]>
Contributor
|
@CompuIves What are we going to do with this once? |
Contributor
|
I am so sorry for closing this :(((((( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be updated with TODO list!