Skip to content

Conversation

@Saeris
Copy link
Contributor

@Saeris Saeris commented Dec 3, 2019

To be updated with TODO list!

@Saeris Saeris added the ✨ Feature Indicates that this adds a new feature. label Dec 3, 2019
@lbogdan
Copy link
Contributor

lbogdan commented Dec 3, 2019

Build for latest commit d3d125f failed.

@Saeris Saeris changed the base branch from master to prototype-common-sync December 3, 2019 11:04
@DannyRuchtie
Copy link
Contributor

I added my remarks in a notion document
https://www.notion.so/Profile-Review-6092bb8fe58e418fafd2891f16655177

CompuIves and others added 13 commits December 13, 2019 11:27
* Put templates under 1 item

* Upgrade dependencies

* Fix weird apollo caching bug

* Fix type error

* Remove need for teamId in unmakeTemplates

* Fix cache update function
* refactored sandbox page to overmind

* fix changing sandbox
* change some zindexes around

* add privacy toggle

* adjust for subscripiton

* doh! undefined check. where is your typescript now

* Fix typing of as

* only show privacy toggle if the user is owner

* not just subscription but also user
* fix text overflow in dashboard

* show ellipses

* remove unsued prop
* Revert "Revert "Privacy popup" (#3204)"

This reverts commit c73d174.

* custom caret

* Make updating privacy optimistic

* Add tracking of updating privacy of a sandbox

* Add tracking for opening the tooltip

* add popup for non owners as well

* track if popup is opened by owner or not
siddharthkp and others added 26 commits January 8, 2020 11:06
* remove duplicate decorator

* add parent styles to layout decorator

* add min height to layout decorator

* add common base element

* use base element for other components

* add all fontsizes + update example
* remove duplicate decorator

* add parent styles to layout decorator

* add min height to layout decorator

* add common base element

* use base element for other components

* add all fontsizes + update example

* add Text, mutedForeground token
* add input

* small fixes

* only show invisible label if no label
* use text inside collapsible

* use size instead of absolute ✨

* prefer element method
* Add noindex to search page

Landing on search page results from a Google search is a poor experience, and Google is struggling to crawl the search pages properly resulting in some weird search results. This change prevents Google from indexing and crawling this page.

* Update index.tsx
* start textarea

* fix counter

* update input to use text component

* remove invisible label

* small fixes

* Update packages/components/src/components/Textarea/index.tsx

Co-Authored-By: Siddharth Kshetrapal <[email protected]>

* update styles

* replace css with style

* get right input

* add type

* fix ts

* clran up types

* fix padding

* add --exit-zero-on-changes

* Update package.json

Co-authored-by: Siddharth Kshetrapal <[email protected]>
* add theme provider

* add box sizing for storybook

Co-authored-by: Sara Vieira <[email protected]>
* add avatr

* fix my merge, sorry :(

* should always be white; wwow that sounds racist

* fix avatar color

* fixed pr comments
* add select component

* move svg to varuable

* add hover

* add icon

* use currentcolor

* remove disabled
* add more tests cases

* use token instead of color
* autosize for textarea

* forgot to remove props
🚧 Progress Commit
* button wip

* write up link + danger

* ts ignores

Co-authored-by: Sara Vieira <[email protected]>
@DannyRuchtie
Copy link
Contributor

@CompuIves What are we going to do with this once?
Close for now? I no longer want to see the PR messages in slack :P

@SaraVieira
Copy link
Contributor

I am so sorry for closing this :((((((

@SaraVieira SaraVieira closed this Jul 2, 2020
@MichaelDeBoey MichaelDeBoey deleted the new-profiles branch July 2, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature Indicates that this adds a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.