Skip to content

Conversation

@garethx
Copy link
Contributor

@garethx garethx commented Jan 8, 2020

Landing on search page results from a Google search is a poor experience, and Google is struggling to crawl the search pages properly resulting in some weird search results. This change prevents Google from indexing and crawling this page.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

https://pr3293.build.csb.dev/search lgtm!

Landing on search page results from a Google search is a poor experience, and Google is struggling to crawl the search pages properly resulting in some weird search results. This change prevents Google from indexing and crawling this page.
@lbogdan
Copy link
Contributor

lbogdan commented Jan 8, 2020

Build for latest commit 0fe46ff is at https://pr3293.build.csb.dev/s/new.

Copy link
Contributor Author

@garethx garethx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was failing due to lack of a closing meta tag - making it self-closing even though I didn't think that was correct, but it seems that's what folks do when using react-helmet.

@SaraVieira
Copy link
Contributor

It's a small difference between react and HTML, all tags in React must be closed otherwise it fails unlike HTML

@SaraVieira SaraVieira merged commit 132041c into master Jan 8, 2020
@SaraVieira SaraVieira deleted the seo-tweak branch January 8, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants