components: use Text in Collapsible #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthkp
commented
Jan 8, 2020
|
|
||
| return ( | ||
| <Element as="section" {...props}> | ||
| <Section {...props}> |
Contributor
Author
There was a problem hiding this comment.
I'm curious, how would it be to write the styles in place -
<Element as="section" css={{fontSize: 3}}>vs
const Section = styled(Element).attrs({ as: 'section' })(
css({
fontSize: 3,
})
);
Contributor
There was a problem hiding this comment.
I perfer the top one but I think we should use the bottom one as it's more js like and I know drake also perfers that one
Contributor
|
Build for latest commit aff16cf is at https://pr3291.build.csb.dev/s/new. |
SaraVieira
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Text inside Collapsible instead of creating new elements.
The stories are especially interesting.