Select component #3298
Merged
Select component #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit 78dc3ce is at https://pr3298.build.csb.dev/s/new. |
siddharthkp
reviewed
Jan 9, 2020
siddharthkp
reviewed
Jan 9, 2020
siddharthkp
reviewed
Jan 9, 2020
| {icon ? <IconWrapper>{icon()}</IconWrapper> : null} | ||
| <SelectComponent icon={Boolean(icon)} id={id} {...props}> | ||
| {props.placeholder ? ( | ||
| <option value="" disabled selected> |
Contributor
There was a problem hiding this comment.
not sure if this should be disabled, this will not allow you to unselect your value
Contributor
Author
There was a problem hiding this comment.
Honestly, either one is fine by me, I saw this being more used but I guess the value is 0 so if we check required we will be good
I will remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds select component