Skip to content

Conversation

@siddharthkp
Copy link
Contributor

@siddharthkp siddharthkp commented Jan 8, 2020

Changes in this PR:

  1. Add missing fontsizes based on figma files
  2. Make layout decorator highlight top level component as well
  3. Implement Element component which provides margin props
  4. Use Element as the base for other library components

@lbogdan
Copy link
Contributor

lbogdan commented Jan 8, 2020

Build for latest commit eb8cbf9 is at https://pr3287.build.csb.dev/s/new.


return (
<section {...props}>
<Element as="section" {...props}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaaaaasssss

@siddharthkp siddharthkp marked this pull request as ready for review January 8, 2020 10:25
@siddharthkp siddharthkp mentioned this pull request Jan 8, 2020
@SaraVieira SaraVieira merged commit bc56b76 into master Jan 8, 2020
@SaraVieira SaraVieira deleted the base-element branch January 8, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants