components: Add theme provider #3294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit f467bdf is at https://pr3294.build.csb.dev/s/new. |
SaraVieira
reviewed
Jan 8, 2020
| margin: 0; | ||
| background-color: ${props => | ||
| props.theme.colors.sideBar.background} !important; | ||
| color: ${props => props.theme.colors.sideBar.foreground} !important; |
Contributor
There was a problem hiding this comment.
its missing the border-box thing
const GlobalStyle = createGlobalStyle`
${global};
html body {
font-family: 'Inter', sans-serif;
background-color: ${theme.colors.sideBar.background};
color: ${theme.colors.sideBar.foreground};
margin: 0;
padding: 20px;
* {
box-sizing: border-box;
}
}
`;
Contributor
Author
There was a problem hiding this comment.
ah yes, will merge with master and bring this along
Contributor
Author
There was a problem hiding this comment.
added box-sizing, removed padding though. Do we need it on body? (I prefer not having anything so that the component behaves in isolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #3292
Moved all the logic of
./storybook/themeto a<ThemeProvider>. This serves as a boundary to a part of the interface which is getting redesigned. Eventually our entire application can be wrapped in just 1 of these.This also gives us the chance to apply globals inside the boundary.