-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Refactor /app/pages/Profile/Sandboxes/index.js to /app/pages/Profile/Sandboxes/index.tsx 🔨 Refactor 🧠 Overmind Hacktoberfest #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…le/Sandboxes/index.tsx`
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/9o6q8i9q7 |
/app/pages/Profile/Sandboxes/index.js to `/app/pages/Profi…
Saeris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some minor changes, you can just batch and commit the suggestions. Otherwise looks great! We don't have a test suite for this specific part of the app, so can you also please manually verify that this still works? I'll try to take a look myself later this week.
Co-Authored-By: Drake Costa <[email protected]>
|
@Saeris I have added the required change. Let me know if you need me to make any more changes. |
|
Hey! I am so sorry it took so long to review this from me but unfortatly this file is now being redesigned and will be merged soon so there is no need to merge this :( I am so sorry and I hope you understand |
What kind of change does this PR introduce?
Refactor #2621 @Saeris @christianalfoni
What is the current behavior?
It was using class component with js file, and cerebral for state management
What is the new behavior?
It now uses tsx instead of js. And Overmind is used for state management with help of
useOvermindhookWhat steps did you take to test this? This is required before we can merge.
yarn lintyarn testyarn typecheckChecklist
In this PR,I changed another file, because it was throwing a typescript error.