Skip to content

Conversation

@Cosmin-B
Copy link
Contributor

With this Pull Request, I am adding the Photon Realtime Guide for users that would like to use Photon as a relay service with Boss Room.

@lkrell lkrell self-requested a review March 29, 2021 16:33
Copy link
Contributor

@lkrell lkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to accept or edit these. Just minor formatting, note/important formatting, etc. Only one question on "their PhotonAppSettings should match with the Host's one." should it be Host's settings?


### Joining a Room

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the --- is needed?

@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Mar 29, 2021
@SamuelBellomo SamuelBellomo added the 1-Needs Review PR needs attention from the assignee and reviewers label Mar 29, 2021
lkrell
lkrell previously approved these changes Mar 29, 2021
Copy link
Contributor

@lkrell lkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from doc side

@lkrell
Copy link
Contributor

lkrell commented Mar 29, 2021

Should this be pointed to 0.1.0-experimental or just 0.1.0?

@Cosmin-B Cosmin-B marked this pull request as ready for review March 29, 2021 19:38
@SamuelBellomo SamuelBellomo merged commit 282eeb9 into release/v0.1.0-experimental Mar 29, 2021
@SamuelBellomo SamuelBellomo deleted the feature/photon-setup-guide branch March 29, 2021 19:54
SamuelBellomo added a commit that referenced this pull request Mar 30, 2021
* release/v0.1.0-experimental: (97 commits)
  adding screenshots (#228)
  [GOMPS-352] Add audiomixer to project (#222)
  feature: transport picker improvements (#200)
  fixing issue where client disconnect boots everyone else (#229)
  removed GC allocs inside of AIBrain (#210)
  init client door with server's current value for IsOpen (#227)
  Photon Realtime Setup Guide for Boss Room (#225)
  Update README.md add link to doc (#226)
  Bug fix: hide icons for unimplemented attacks
  feature: v0.1.0 experimental updating to latest master mlapi (#220)
  fixing missing reference exceptions, and missing animation (#219)
  feat: replace with photon package (#218)
  Replaced LobbyPlayerArray with a NetworkList<LobbyPlayerState> (#217)
  ART:  Warning Message fixes for models, animations, and Shader...and new App icon (#213)
  Updating to latest MLAPI on master (#214)
  null guard added inside of target action for accessing a possibly destroyed reticule (#212)
  [GOMPS-270] bossroom should let users specify connection port# (#205)
  Fix useless log error (#203)
  Bugfix: properly disconnect on quit [GOMPS-324][GOMPS-327][GOMPS-385] (#196)
  Volume control [GOMPS-373] (#195)
  ...

# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 1-Needs Review PR needs attention from the assignee and reviewers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants