Skip to content

feature: transport picker improvements #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 30, 2021
Merged

feature: transport picker improvements #200

merged 8 commits into from
Mar 30, 2021

Conversation

@LukeStampfli
Copy link
Contributor

@LukeStampfli LukeStampfli commented Mar 24, 2021 •
edited
Loading

  • Removes the LiteNetLib source from the project.
  • Adds the 0.1.0 version of the LiteNetLib as a Unity package to the project. (I tested with client + host killed an imp it worked). Should be exactly the same source files.
  • Fix a bug where transport picker would not allow you to switch ip transport (to litenetlib)
  • Move transport picker to the top of the NetworkManager gameobject for visibility
  • Add a section about transports and how we use them to Architecture.md

@LukeStampfli LukeStampfli requested review from SamuelBellomo and removed request for SamuelBellomo March 24, 2021 00:33
pdeschain
pdeschain previously approved these changes Mar 24, 2021
View reviewed changes
@pdeschain pdeschain self-assigned this Mar 24, 2021
@pdeschain pdeschain added the 2-One More Review One review in, one to go label Mar 24, 2021
@SamuelBellomo SamuelBellomo self-assigned this Mar 26, 2021
SamuelBellomo
SamuelBellomo reviewed Mar 26, 2021
View reviewed changes
SamuelBellomo
SamuelBellomo previously approved these changes Mar 26, 2021
View reviewed changes
@SamuelBellomo SamuelBellomo added the 2-Reviewed with Comments PR requires owner's attention label Mar 26, 2021
@SamuelBellomo
Copy link
Contributor

SamuelBellomo commented Mar 26, 2021

approving once comment above is fixed

@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Mar 26, 2021
@LukeStampfli
Merge remote-tracking branch 'origin/release/v0.1.0-experimental' int…
847bdfb 
…o feature/transport-picker-improvements

# Conflicts:
#	Assets/BossRoom/Prefabs/NetworkingManager.prefab
#	Assets/BossRoom/Scripts/Client/Net/ClientGameNetPortal.cs
#	Assets/BossRoom/Scripts/Shared/Game/UI/Editor/NetworkLatencyWarning.cs
#	Assets/BossRoom/Scripts/Shared/Net/GameNetPortal.cs
#	Assets/BossRoom/Scripts/Shared/TransportPicker.cs
#	Packages/manifest.json
#	Packages/packages-lock.json
@LukeStampfli
chore: remove dependencies from transport packages
0a1ba6a
@LukeStampfli LukeStampfli dismissed stale reviews from SamuelBellomo and pdeschain via 0a1ba6a March 30, 2021 10:21
@LukeStampfli LukeStampfli added 1-Needs Review PR needs attention from the assignee and reviewers and removed 2-One More Review One review in, one to go 2-Reviewed with Comments PR requires owner's attention labels Mar 30, 2021
@SamuelBellomo SamuelBellomo merged commit 78f118c into release/v0.1.0-experimental Mar 30, 2021
@SamuelBellomo SamuelBellomo deleted the feature/transport-picker-improvements branch March 30, 2021 14:26
@pdeschain pdeschain added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 30, 2021
SamuelBellomo added a commit that referenced this pull request Mar 30, 2021
@SamuelBellomo
Merge branch 'release/v0.1.0-experimental' into master
7a2bed6 
* release/v0.1.0-experimental: (97 commits)
  adding screenshots (#228)
  [GOMPS-352] Add audiomixer to project (#222)
  feature: transport picker improvements (#200)
  fixing issue where client disconnect boots everyone else (#229)
  removed GC allocs inside of AIBrain (#210)
  init client door with server's current value for IsOpen (#227)
  Photon Realtime Setup Guide for Boss Room (#225)
  Update README.md add link to doc (#226)
  Bug fix: hide icons for unimplemented attacks
  feature: v0.1.0 experimental updating to latest master mlapi (#220)
  fixing missing reference exceptions, and missing animation (#219)
  feat: replace with photon package (#218)
  Replaced LobbyPlayerArray with a NetworkList<LobbyPlayerState> (#217)
  ART:  Warning Message fixes for models, animations, and Shader...and new App icon (#213)
  Updating to latest MLAPI on master (#214)
  null guard added inside of target action for accessing a possibly destroyed reticule (#212)
  [GOMPS-270] bossroom should let users specify connection port# (#205)
  Fix useless log error (#203)
  Bugfix: properly disconnect on quit [GOMPS-324][GOMPS-327][GOMPS-385] (#196)
  Volume control [GOMPS-373] (#195)
  ...

# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdeschain pdeschain pdeschain approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 3-Good to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeStampfli @SamuelBellomo @pdeschain