Bugfix: properly disconnect on quit [GOMPS-324][GOMPS-327][GOMPS-385] #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The "game state" object base class now handles OnApplicationQuit() and calls StopClient(), StopServer(), or StopHost() as appropriate - There was no client-side game logic for the post-game scene, so added one (just a stub so that the base-class gets called) - Fixed a bug with shutdown logic that doesn't check whether the NetworkManager.Singleton has become null. (There may be more of these -- they're hard to find because object-destruction order is unpredictable. But I didn't see any more after starting/stopping the client a few dozen times.)
eheimburg
changed the title
Contributor
Author
|
Also checked in [GOMPS-327] here. (Previously this bug was FIXME'd because of MLAPI problems, but those problems are contained now) |
SamuelBellomo
added
the
1-Needs Review
eheimburg
changed the title
Contributor
Author
|
A note -- [GOMPS-385] is also fixed by this checkin. That's the bug where pressing "Main Menu" on the post-game screen will crash if the host has quit. With this PR, the player will automatically leave the post-game screen as soon as the host quits, so they can't get into that invalid state. |
LukeStampfli
approved these changes
Mar 24, 2021
pdeschain
approved these changes
Mar 26, 2021
pdeschain
added
3-Good to Merge
and removed
1-Needs Review
SamuelBellomo
added a commit
that referenced
this pull request
Mar 30, 2021
* release/v0.1.0-experimental: (97 commits) adding screenshots (#228) [GOMPS-352] Add audiomixer to project (#222) feature: transport picker improvements (#200) fixing issue where client disconnect boots everyone else (#229) removed GC allocs inside of AIBrain (#210) init client door with server's current value for IsOpen (#227) Photon Realtime Setup Guide for Boss Room (#225) Update README.md add link to doc (#226) Bug fix: hide icons for unimplemented attacks feature: v0.1.0 experimental updating to latest master mlapi (#220) fixing missing reference exceptions, and missing animation (#219) feat: replace with photon package (#218) Replaced LobbyPlayerArray with a NetworkList<LobbyPlayerState> (#217) ART: Warning Message fixes for models, animations, and Shader...and new App icon (#213) Updating to latest MLAPI on master (#214) null guard added inside of target action for accessing a possibly destroyed reticule (#212) [GOMPS-270] bossroom should let users specify connection port# (#205) Fix useless log error (#203) Bugfix: properly disconnect on quit [GOMPS-324][GOMPS-327][GOMPS-385] (#196) Volume control [GOMPS-373] (#195) ... # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnApplicationQuit()and callsStopClient(),StopServer(), orStopHost()as appropriateEdit: another bug-fix needed the fixes from this PR, so I bundled it into the same branch: