removed GC allocs inside of AIBrain #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
dwoodruffsf
previously approved these changes
Mar 26, 2021
SamuelBellomo
added
2-Reviewed with Comments
fernando-cortez
removed
the
2-Reviewed with Comments
dwoodruffsf
approved these changes
Mar 29, 2021
pdeschain
approved these changes
Mar 29, 2021
pdeschain
added
3-Good to Merge
and removed
1-Needs Review
SamuelBellomo
added a commit
that referenced
this pull request
Mar 30, 2021
* release/v0.1.0-experimental: (97 commits) adding screenshots (#228) [GOMPS-352] Add audiomixer to project (#222) feature: transport picker improvements (#200) fixing issue where client disconnect boots everyone else (#229) removed GC allocs inside of AIBrain (#210) init client door with server's current value for IsOpen (#227) Photon Realtime Setup Guide for Boss Room (#225) Update README.md add link to doc (#226) Bug fix: hide icons for unimplemented attacks feature: v0.1.0 experimental updating to latest master mlapi (#220) fixing missing reference exceptions, and missing animation (#219) feat: replace with photon package (#218) Replaced LobbyPlayerArray with a NetworkList<LobbyPlayerState> (#217) ART: Warning Message fixes for models, animations, and Shader...and new App icon (#213) Updating to latest MLAPI on master (#214) null guard added inside of target action for accessing a possibly destroyed reticule (#212) [GOMPS-270] bossroom should let users specify connection port# (#205) Fix useless log error (#203) Bugfix: properly disconnect on quit [GOMPS-324][GOMPS-327][GOMPS-385] (#196) Volume control [GOMPS-373] (#195) ... # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira task here. You can consider this as part 1 of more optimization PRs.
For this PR, I took a look at just the GC allocs while in the Boss Room scene. So as far as allocs go, there's none anymore. The two screenshots of the profiler are taken right after spawning.
Pre:
Post:
Effectively, this kills all of the 20kb per frame of allocs. The highlighted 60B in the post png is just an Assert so we're at 0B of GC allocs in builds (at this part of the level).
Stay tuned for the next optimization pass.