Skip to content

Conversation

@SyntaxKay
Copy link
Owner

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Stanislav Idolov and others added 30 commits October 16, 2018 11:08
…nel #18638

 - Merge Pull Request #18638 from speedy008/magento2:fix-issue-18581-2.3
 - Merged commits:
   1. 039c88d
 - Merge Pull Request #18573 from zack6849/magento2:2.3-develop
 - Merged commits:
   1. d1d5fdb
   2. cda6aa1
Accepted Public Pull Requests:
 - #18545: [Forwardport] Fix type hint of @message declaration as the "setWidgetParameters" method allows arrays too (by @mage2pratik)
 - #18538: [Forwardport] Admin > Footer > Aligning Proportionally (by @dmytro-ch)
 - #18540: Fixed typo from heght to height for image validation rule (by @peterjaap)
 - #18065: Fix bool scope config and update throws and update use clases (by @hryvinskyi)
 - #18529: Create empty modelData array to avoid undefined var error (by @peterjaap)
 - #18522:  Fix typo on product details causing Validation error.  (by @BezV8)
 - #18393: Fix for #12969 - server port detection for errors (by @loganstellway)
 - #18365: move hardcoded MIME types from class private to DI configuration. (by @tufahu)
 - #18476: Fix Typo in Data\Form\Element\Factory.php (by @zack6849)
 - #18494: Checkout - Fix "Cannot read property 'code' on undefined" issue (by @ihor-sviziev)
 - #18507: [Forwardport] add error message in else condition (by @vaibhavahalpara)
 - #18437: MAGENTO-18131: Fixed EAV attributes values query (by @strell)
 - #18370: [Forwardport] ConfigurableProduct show prices in select options (by @ihor-sviziev)
 - #18210: [Forwardport] Fixes saving product in single-store mode if website_id <> 1 (by @eduard13)
 - #18160: Fix of saving "clone_field" fields  (by @higi90)


Fixed GitHub Issues:
 - #12969: processor.php getHostUrl() does not detect the server port correctly (reported by @boldhedgehog) has been fixed in #18393 by @loganstellway in 2.3-develop branch
   Related commits:
     1. 422d244
     2. 1e28a8e
     3. 7d921b6

 - #18164: Checkout - Cannot read property 'code' of undefined (reported by @bruno-serfe) has been fixed in #18494 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. 47978d7
     2. 0fcbe12

 - #17977: Show Method if Not Applicable for Free Shipping doesn't work. (reported by @vaibhavahalpara) has been fixed in #18507 by @vaibhavahalpara in 2.3-develop branch
   Related commits:
     1. 9b7d4ac
     2. 67e1b01
     3. 4938bbc

 - #18131: Entity Type ID at Join (reported by @akimatze) has been fixed in #18437 by @strell in 2.3-develop branch
   Related commits:
     1. 2f4ad2f

 - #13405: No such entity error when saving product in single-store mode if website_id <> 1 (reported by @kyegil) has been fixed in #18210 by @eduard13 in 2.3-develop branch
   Related commits:
     1. 765f88f
     2. 558d527
     3. deebbc0
     4. ae2917c
     5. e068783
     6. 7cd36de
     7. 0e7f779
     8. 1133391
…down) display behavior on storefront is not per standards (PFA snap)

- make sure multiselect doesn't show background image
- added step to check if config tab for wysiwyg is opened
magento-engcom-team and others added 7 commits October 24, 2018 18:46
 - merged latest code from mainline branch
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - #18708: Cover \Magento\GiftMessage\Observer\SalesEventQuoteMerge with Unit test (by @vasilii-b)
 - #18733: Correct a typo in the reference to ISO language codes (by @mage2pratik)
 - #18723: Updated links in README (by @StrikerRUS)
 - #18694: Added Unit Test for WindowsSmtpConfig Plugin (by @vasilii-b)
 - #18707: Cover \Magento\Email\Model\Template\SenderResolver class with Unit test (by @vasilii-b)
 - #18710: [Elasticsearch] Covering the CategoryProductIndexer by Unit Test (by @eduard13)
 - #18284: save the custom option price when it is 0 (by @amatanovic)
 - #18702: [Forwardport][2.3] of MAGETWO-93818: Magnifier function does not disappear after mouse-off the image from the bottom (by @gwharton)
 - #17300: Add ReadFactory and WriteFactory to Magento's public API (by @navarr)
 - #17296: Add Value to Magento Framework's public API (by @navarr)
 - #18671: Remove unnecessary class import, see #18117 (by @sreichel)
 - #18667: Fixed class name issue in comment (by @gelanivishal)
 - #18627: Fixed incorrect datepicker icon position in admin panel (by @rogyar)
 - #18614: Braintree Paypal Review: check if variable is array when validating request data (by @deninchoo)
 - #18488: Fix issue with unexpected changing of subscription status after customer saving (by @alexeya-ven)
 - #18333: Support of error pages behind a load balancer that serves HTTPS  (by @stkams)
 - #18080: Add checkout_cart_product_add_before event #17830 (by @leandro-rosa)


Fixed GitHub Issues:
 - #2686: 500 Internal Server Error upon clicking SAVE button of product record adding/editing (reported by @protodevsystems) has been fixed in #18733 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. a4b5cc1

 - #17616: Importer fails when updating an existing product with custom options (reported by @simonworkhouse) has been fixed in #18284 by @amatanovic in 2.3-develop branch
   Related commits:
     1. 4c76f9a
     2. 74ca77c

 - #15035: [2.2.4] Gallery Magnifier hover event does not always cancel magnifier when mouse leaves gallery (reported by @gwharton) has been fixed in #18702 by @gwharton in 2.3-develop branch
   Related commits:
     1. 031d8ec
     2. 4b76ffd

 - #18605: Calendar Icon is displaced at the Backend (reported by @larsroettig) has been fixed in #18627 by @rogyar in 2.3-develop branch
   Related commits:
     1. 3f0e9a4

 - #17830: Add checkout_cart_product_add_before event (reported by @peterjaap) has been fixed in #18080 by @leandro-rosa in 2.3-develop branch
   Related commits:
     1. 7b728b1
     2. f9389ad
     3. fef2205
     4. 0de795a
@SyntaxKay SyntaxKay merged commit 7401795 into SyntaxKay:2.3-develop Oct 27, 2018
SyntaxKay pushed a commit that referenced this pull request Oct 30, 2018
SyntaxKay pushed a commit that referenced this pull request Nov 3, 2018
SyntaxKay pushed a commit that referenced this pull request Nov 3, 2018
SyntaxKay pushed a commit that referenced this pull request Nov 3, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
SyntaxKay pushed a commit that referenced this pull request Nov 14, 2018
SyntaxKay pushed a commit that referenced this pull request Nov 14, 2018
Remove unnecesary "header" block redeclaration
SyntaxKay pushed a commit that referenced this pull request Nov 24, 2018
SyntaxKay pushed a commit that referenced this pull request Nov 24, 2018
SyntaxKay pushed a commit that referenced this pull request Dec 8, 2018
SyntaxKay pushed a commit that referenced this pull request Dec 8, 2018
SyntaxKay pushed a commit that referenced this pull request Dec 8, 2018
SyntaxKay pushed a commit that referenced this pull request Dec 15, 2018
SyntaxKay pushed a commit that referenced this pull request Jan 11, 2019
SyntaxKay pushed a commit that referenced this pull request Jan 11, 2019
Missing setTotalCount on $searchResults object in getList method
SyntaxKay pushed a commit that referenced this pull request Jan 29, 2019
removes extra dot on "How to run Magento" in phpserve/README.md
SyntaxKay pushed a commit that referenced this pull request Feb 14, 2019
Add Brazilian Credit Cards Support #1
SyntaxKay pushed a commit that referenced this pull request Feb 14, 2019
SyntaxKay pushed a commit that referenced this pull request Jun 7, 2019
SyntaxKay pushed a commit that referenced this pull request Jul 8, 2019
SyntaxKay pushed a commit that referenced this pull request Dec 13, 2019
SyntaxKay pushed a commit that referenced this pull request Dec 13, 2019
…rrors

Filter error array by unique values
SyntaxKay pushed a commit that referenced this pull request Dec 13, 2019
update forked repository 2.3 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.