Skip to content

Conversation

peterjaap
Copy link
Contributor

Description

Create empty modelData array to avoid undefined var error further in the function if the change type is not one of the listed cases

Fixed Issues (if relevant)

None

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Oct 11, 2018

@magento-engcom-team combine 18530

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@peterjaap all pull requests have been successfully combined together:

@sidolov
Copy link
Contributor

sidolov commented Oct 11, 2018

@magento-engcom-team combine 18531

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@peterjaap all pull requests have been successfully combined together:

@magento-engcom-team
Copy link
Contributor

Hi @peterjaap. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@peterjaap peterjaap deleted the instantiate-possible-undefined-var branch September 30, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants