Skip to content

Conversation

@eduard13
Copy link
Contributor

Original Pull Request

#18001

Description

This PR fixes the saving product in a single store mode, where the default website was removed, and a new one it is used instead.

Fixed Issues (if relevant)

  1. No such entity error when saving product in single-store mode if website_id <> 1 #13405: No such entity error when saving product in single-store mode if website_id <> 1

Manual testing scenarios

  1. Install a clean version of Magento version 2.2.2
  2. Add a new website, store and store view, and make this the default
  3. Delete the preinstalled website, store and store view
  4. Add a new product and save it
  5. Change the configurations to single-store mode
  6. Open the product and save it again

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Catalog Release Line: 2.3 labels Sep 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Sep 24, 2018

Please, consider fixing the failing static tests. The issues might not be related directly to your changes but to files that were changed in general. If you need help with that, feel free to connect me in Slack

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 2, 2018

CLA assistant check
All committers have signed the CLA.

@slavvka slavvka self-assigned this Oct 2, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3078 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants