-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Added Unit Test for WindowsSmtpConfig Plugin #18694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Unit Test for WindowsSmtpConfig Plugin #18694
Conversation
Hi @vasilii-b. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, declare the strict types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not look like a "mock". We test the real object. Please, fix the naming.
Hello @vasilii-b. Thank you for your contribution. Please, consider fixing a few minor issues mentioned in the review |
Thank you @rogyar, will do. |
6af2e0f
to
4f27ece
Compare
Hi @rogyar , I have added requested changes, but I see the Codacy failed with a strange issue. Could you please have a look and advice what to do there ? 🤔 Thank you! |
4f27ece
to
1872979
Compare
I've double checked the result and see no issue. So, no worries |
Hi @rogyar, thank you for the review. |
Hi @vasilii-b. Thank you for your contribution. |
Description
This PR cover
Magento\Email\Test\Unit\Model\Plugin\WindowsSmtpConfig
plugin with unit test.Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist (*)