Skip to content

Conversation

vasilii-b
Copy link

Description

This PR cover Magento\Email\Test\Unit\Model\Plugin\WindowsSmtpConfig plugin with unit test.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vasilii-b vasilii-b requested a review from rogyar October 19, 2018 06:55
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.3 labels Oct 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, declare the strict types.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not look like a "mock". We test the real object. Please, fix the naming.

@rogyar
Copy link
Contributor

rogyar commented Oct 19, 2018

Hello @vasilii-b. Thank you for your contribution. Please, consider fixing a few minor issues mentioned in the review

@vasilii-b
Copy link
Author

Thank you @rogyar, will do.

@vasilii-b vasilii-b force-pushed the 2.3-WindowsSmtpConfigTest branch from 6af2e0f to 4f27ece Compare October 19, 2018 15:02
@vasilii-b
Copy link
Author

Hi @rogyar , I have added requested changes, but I see the Codacy failed with a strange issue. Could you please have a look and advice what to do there ? 🤔 Thank you!

@vasilii-b vasilii-b force-pushed the 2.3-WindowsSmtpConfigTest branch from 4f27ece to 1872979 Compare October 19, 2018 18:13
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 20, 2018
@rogyar
Copy link
Contributor

rogyar commented Oct 20, 2018

I've double checked the result and see no issue. So, no worries

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3234 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@vasilii-b vasilii-b deleted the 2.3-WindowsSmtpConfigTest branch October 25, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Email Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants