Skip to content

Conversation

@SyntaxKay
Copy link
Contributor

@SyntaxKay SyntaxKay commented Oct 16, 2018

Original Pull Request

#18593

Description (*)

solved calender icon issue in advance pricing in adminpanel

Fixed Issues (if relevant)

  1. magento/magento2 Calendar Icon aligement Issue  #18581 : Calendar Icon aligement Issue

Manual testing scenarios (*)

  1. Open the special price for simple products
  2. screenshot from 2018-10-13 14-16-08
    3.Now icon displays in proper alignment

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 16, 2018
@SyntaxKay SyntaxKay changed the title solved calender icon issue in advance pricing in adminpanel [Forwardport] Calendar icon in advance pricing alignment solved Oct 18, 2018
@magento-engcom-team magento-engcom-team merged commit 039c88d into magento:2.3-develop Oct 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants