Skip to content

Conversation

@ihor-sviziev
Copy link
Contributor

Original Pull Request

#17695

Description

In Magento2 by default we can't show configurable product prices in select options, as it was done in custom options. There only labels with product name there. My improvement fixes that problem.

Manual testing scenarios

  1. Add some configurable products to product in backend. Some options should have different price than another.
  2. Open product page and click on the select which contains allowed products

Expected result:
You can see labels with prices

Actual result:
You can see labels without prices, but when you choose some of label, product price is updating

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

arendarenko and others added 5 commits October 4, 2018 02:41
- Add feature to show price of customized product in select on product page
- Fix isShowSign parameter passing that adds "+" or "-" to the option. Previously there was a bug because this parameter should be boolean.
- Remove unused variable
- Fix code style errors
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3089 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@ihor-sviziev ihor-sviziev deleted the 2.3-develop-PR-port-17695 branch October 16, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants