Skip to content

Conversation

@navarr
Copy link
Contributor

@navarr navarr commented Jul 31, 2018

Description

These classes are necessary/useful for creating instances of
ReadInterface and WriteInterface using the public API.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

These classes are necessary/useful for creating instances of
ReadInterface and WriteInterface using the public API.
@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ishakhsuvarov ishakhsuvarov added this to the Release: 2.3.1 milestone Sep 18, 2018
@slavvka slavvka self-assigned this Oct 4, 2018
@navarr
Copy link
Contributor Author

navarr commented Oct 17, 2018

@slavvka Hi - why is this PR on hold? Is there anything I can do to move it along?

@slavvka
Copy link
Member

slavvka commented Oct 17, 2018

@navarr because it should be delivered to 2.3 release and 2.3-develop isn't a release branch anymore. I am going to deliver it there together with #17296 where I asked you to make changes according to our decision.

Copy link
Member

@slavvka slavvka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navarr thank you for your valuable contribution! Your changes was cherry-picked and delivered to 2.3.0 release branch. This PR is also accepted and will be delivered to 2.3.1 release

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Oct 18, 2018
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3222 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 2a3562f into magento:2.3-develop Oct 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants