-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add ReadFactory and WriteFactory to Magento's public API #17300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReadFactory and WriteFactory to Magento's public API #17300
Conversation
These classes are necessary/useful for creating instances of ReadInterface and WriteInterface using the public API.
|
Hi @navarr. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@slavvka Hi - why is this PR on hold? Is there anything I can do to move it along? |
slavvka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navarr thank you for your valuable contribution! Your changes was cherry-picked and delivered to 2.3.0 release branch. This PR is also accepted and will be delivered to 2.3.1 release
|
Hi @slavvka, thank you for the review. |
|
Hi @navarr. Thank you for your contribution. |
Description
These classes are necessary/useful for creating instances of
ReadInterface and WriteInterface using the public API.
Contribution checklist