boards: atsame54_xpro: Add SAM E54 Xplained Pro Evaluation Kit #20063

benpicco · 2019-10-23T11:01:27Z

This adds support for the Atmel SAM E54 Xplained Pro Evaluation Kit.

split off from #14685
depends on ~~#20062~~ ~~#20056~~ ~~#20058~~
additional functionality depends on ~~#20052~~ ~~#20055~~ ~~#20057~~ ~~#21866~~

zephyrbot · 2019-10-23T12:35:52Z

All checks are passing now.

checkpatch (informational only, not a failure)

-:61: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atsame54,xpro" appears un-documented -- check ./dts/bindings/
#61: FILE: boards/arm/atsame54_xpro/atsame54_xpro.dts:12:
+	compatible = "atsame54,xpro", "atmel,same54p20a", "atmel,same54";

-:61: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string vendor "atsame54" appears un-documented -- check ./dts/bindings/vendor-prefixes.txt
#61: FILE: boards/arm/atsame54_xpro/atsame54_xpro.dts:12:
+	compatible = "atsame54,xpro", "atmel,same54p20a", "atmel,same54";

-:61: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,same54p20a" appears un-documented -- check ./dts/bindings/
#61: FILE: boards/arm/atsame54_xpro/atsame54_xpro.dts:12:
+	compatible = "atsame54,xpro", "atmel,same54p20a", "atmel,same54";

-:61: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,same54" appears un-documented -- check ./dts/bindings/
#61: FILE: boards/arm/atsame54_xpro/atsame54_xpro.dts:12:
+	compatible = "atsame54,xpro", "atmel,same54p20a", "atmel,same54";

-:87: WARNING:LONG_LINE: line over 80 characters
#87: FILE: boards/arm/atsame54_xpro/atsame54_xpro.dts:38:
+			gpios = <&portb 31 (GPIO_PUD_PULL_UP | GPIO_INT_ACTIVE_LOW)>;

- total: 0 errors, 5 warnings, 556 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

dbkinder

doc change LGTM, thanks.

galak

Can you shrink the images, they are huge (file size).

Does this only need the SoC PR, or do we need UART driver? GPIO driver? [ what's the minimal set of SoC + drivers to make the board code useful ].

benpicco · 2019-11-06T20:53:58Z

Down to

808K ATSAME54-XPRO-pinout.png 
596K atsame54_xpro.png

If you just want to blink an LED, the SoC PR is enough.
The GPIO PR is about EXTI (and port D), basic GPIO functionality is the same as on samd2x.

UART would be nice of course. 😉

galak · 2019-11-06T21:15:04Z

Down to
808K ATSAME54-XPRO-pinout.png 
596K atsame54_xpro.png
If you just want to blink an LED, the SoC PR is enough.
The GPIO PR is about EXTI (and port D), basic GPIO functionality is the same as on samd2x.

UART would be nice of course. 😉

Sent you on slack a much smaller image, take a look and see what you think.

galak · 2019-11-07T13:31:18Z

@benpicco can you look at addressing the build issues / sanitycheck failures. If you want this in for 2.1 we need to resolve this by friday (Nov 8th).

benpicco · 2019-11-07T13:53:11Z

I forgot to also move the flash and sram blocks in the samd5xx20.dtsi etc DTS files after moving it in samd5x.dts - this is fixed by #20420

Then the DTS processor will complain about the unknown lock regions property introduced by #20058 - you'll get past the config with this PR 😉

Then soc.h wants to include tc_fixup_samd5x.h which is introduced by #20056

With these three, hello_world compiles.

ioannisg · 2019-11-07T14:00:42Z

This adds support for the Atmel SAM E54 Xplained Pro Evaluation Kit.

split off from #14685
depends on #20062

#20062 is merged; update the description :)

boards/arm/atsame54_xpro/Kconfig.board

tests/drivers/spi/spi_loopback/boards/atsame54_xpro.conf

ioannisg

The test file looks not relevant to the PR.
Some clean up of the Kconfig file headers is needed.
Looking good, otherwise

galak · 2019-11-07T18:10:10Z

@benpicco still major CI failures

benpicco · 2019-11-08T09:51:01Z

@galak I removed references the not yet merged features.

benpicco · 2019-11-27T15:18:57Z

If the other PRs get merged before this, I will remove the last few commits here.

ioannisg · 2020-01-23T13:06:57Z

@benpicco can you address the checkpatch warnings?

benpicco · 2020-01-23T13:23:22Z

@ioannisg I'm not sure how - I can't find documentation for the vendor strings in atsamd21_xpro.dts either - where should they go?

ioannisg · 2020-01-23T17:36:10Z

@galak can you take a look?

This adds support for the Atmel SAM E54 Xplained Pro Evaluation Kit. Only basic functionality has been tested so far. Signed-off-by: Benjamin Valentin <[email protected]>

The blocks were moved into the soc block in samd5x.dtsi, so we also have to move them for the the actual SoC definitions that inherit from that. Signed-off-by: Benjamin Valentin <[email protected]>

`cortex_m/exc.h` is not needed anymore and ceased to exist. Signed-off-by: Benjamin Valentin <[email protected]>

It's not needed anymore and causes build failures. Signed-off-by: Benjamin Valentin <[email protected]>

benpicco · 2020-01-30T14:45:08Z

Thank you for the review & merge!

benpicco added area: Boards platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Oct 23, 2019

benpicco requested a review from galak October 23, 2019 11:01

benpicco requested review from MaureenHelm, dbkinder and tbursztyka as code owners October 23, 2019 11:01

zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 23, 2019

dbkinder approved these changes Oct 23, 2019

View reviewed changes

galak requested changes Nov 6, 2019

View reviewed changes

benpicco force-pushed the same54-xpro branch from 5a9ce4b to fd57b01 Compare November 6, 2019 20:51

benpicco force-pushed the same54-xpro branch from fd57b01 to eb4698c Compare November 6, 2019 21:20

galak force-pushed the same54-xpro branch from eb4698c to f1d2d32 Compare November 7, 2019 03:18

galak mentioned this pull request Nov 7, 2019

dts: atmel_sam0: fix location of flash and sram blocks #20420

Closed

benpicco requested a review from ioannisg as a code owner November 7, 2019 13:57

zephyrbot added the area: Devicetree label Nov 7, 2019

ioannisg reviewed Nov 7, 2019

View reviewed changes

boards/arm/atsame54_xpro/Kconfig.board Outdated Show resolved Hide resolved

ioannisg reviewed Nov 7, 2019

View reviewed changes

tests/drivers/spi/spi_loopback/boards/atsame54_xpro.conf Outdated Show resolved Hide resolved

ioannisg suggested changes Nov 7, 2019

View reviewed changes

benpicco force-pushed the same54-xpro branch 2 times, most recently from 014fac6 to fdacbef Compare November 7, 2019 15:45

ioannisg added the Release Notes To be mentioned in the release notes label Nov 7, 2019

ioannisg approved these changes Nov 7, 2019

View reviewed changes

ioannisg requested a review from galak November 7, 2019 16:03

stephanosio added this to the v2.2.0 milestone Nov 22, 2019

stephanosio self-requested a review December 11, 2019 13:57

benpicco force-pushed the same54-xpro branch from 9e02590 to ed7703b Compare December 19, 2019 14:40

benpicco force-pushed the same54-xpro branch 2 times, most recently from 1db08fb to fab1a3d Compare January 14, 2020 16:20

benpicco force-pushed the same54-xpro branch 2 times, most recently from 59c3484 to f4664db Compare January 23, 2020 12:53

galak self-assigned this Jan 29, 2020

galak force-pushed the same54-xpro branch from 45a84f4 to d39ed6c Compare January 30, 2020 10:43

benpicco requested a review from nashif as a code owner January 30, 2020 10:43

galak approved these changes Jan 30, 2020

View reviewed changes

galak force-pushed the same54-xpro branch from d39ed6c to c263f64 Compare January 30, 2020 11:06

benpicco and others added 4 commits January 30, 2020 07:07

boards: atsame54_xpro: Add SAM E54 Xplained Pro Evaluation Kit

156dc9b

This adds support for the Atmel SAM E54 Xplained Pro Evaluation Kit. Only basic functionality has been tested so far. Signed-off-by: Benjamin Valentin <[email protected]>

dts: atmel_sam0: fix location of flash and sram blocks

5ec20a4

The blocks were moved into the soc block in samd5x.dtsi, so we also have to move them for the the actual SoC definitions that inherit from that. Signed-off-by: Benjamin Valentin <[email protected]>

soc: atmel_sam0: remove obsolete include

18730b6

`cortex_m/exc.h` is not needed anymore and ceased to exist. Signed-off-by: Benjamin Valentin <[email protected]>

soc: atmel_sam0: remove CONFIG_ENTROPY_NAME from dts_fixup.h

e9c39eb

It's not needed anymore and causes build failures. Signed-off-by: Benjamin Valentin <[email protected]>

galak force-pushed the same54-xpro branch from c263f64 to e9c39eb Compare January 30, 2020 13:07

galak merged commit 6fd08da into zephyrproject-rtos:master Jan 30, 2020

benpicco deleted the same54-xpro branch January 30, 2020 14:44

boards: atsame54_xpro: Add SAM E54 Xplained Pro Evaluation Kit #20063

boards: atsame54_xpro: Add SAM E54 Xplained Pro Evaluation Kit #20063

Uh oh!

Conversation

benpicco commented Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

checkpatch (informational only, not a failure)

Uh oh!

dbkinder left a comment

Choose a reason for hiding this comment

Uh oh!

galak left a comment

Choose a reason for hiding this comment

Uh oh!

benpicco commented Nov 6, 2019

Uh oh!

galak commented Nov 6, 2019

Uh oh!

galak commented Nov 7, 2019

Uh oh!

benpicco commented Nov 7, 2019

Uh oh!

ioannisg commented Nov 7, 2019

Uh oh!

Uh oh!

Uh oh!

ioannisg left a comment

Choose a reason for hiding this comment

Uh oh!

galak commented Nov 7, 2019

Uh oh!

benpicco commented Nov 8, 2019

Uh oh!

benpicco commented Nov 27, 2019

Uh oh!

ioannisg commented Jan 23, 2020

Uh oh!

benpicco commented Jan 23, 2020

Uh oh!

ioannisg commented Jan 23, 2020

Uh oh!

benpicco commented Jan 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

benpicco commented Oct 23, 2019 •

edited

Loading

zephyrbot commented Oct 23, 2019 •

edited

Loading