Skip to content

Conversation

@benpicco
Copy link
Contributor

The SPI SERCOM peripheral found on the SAMD5x/SAME5x is very much alike
the one found in previous SAM0 MCUs.

Only the clock setup is different.

split off from #14685

The SPI SERCOM peripheral found on the SAMD5x/SAME5x is very much alike
the one found in previous SAM0 MCUs.

Only the clock setup is different.

Signed-off-by: Benjamin Valentin <[email protected]>
@benpicco benpicco added area: SPI SPI bus platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Oct 23, 2019
@benpicco benpicco requested a review from galak October 23, 2019 10:49
@benpicco benpicco requested a review from tbursztyka as a code owner October 23, 2019 10:49
@zephyrbot
Copy link

zephyrbot commented Oct 23, 2019

All checks passed.

checkpatch (informational only, not a failure)

-:68: WARNING:LONG_LINE: line over 80 characters
#68: FILE: drivers/spi/spi_sam0.c:783:
+#define SPI_SAM0_DEFINE_CONFIG(n)						\

-:69: WARNING:LONG_LINE: line over 80 characters
#69: FILE: drivers/spi/spi_sam0.c:784:
+	static const struct spi_sam0_config spi_sam0_config_##n = {		\

-:70: WARNING:LONG_LINE: line over 80 characters
#70: FILE: drivers/spi/spi_sam0.c:785:
+		.regs = (SercomSpi *)DT_ATMEL_SAM0_SPI_SERCOM_##n##_BASE_ADDRESS,\

-:71: WARNING:LONG_LINE: line over 80 characters
#71: FILE: drivers/spi/spi_sam0.c:786:
+		.mclk = MCLK_SERCOM##n,						\

-:72: WARNING:LONG_LINE: line over 80 characters
#72: FILE: drivers/spi/spi_sam0.c:787:
+		.mclk_mask = MCLK_SERCOM##n##_MASK,				\

-:73: WARNING:LONG_LINE: line over 80 characters
#73: FILE: drivers/spi/spi_sam0.c:788:
+		.gclk_core_id = SERCOM##n##_GCLK_ID_CORE,			\

-:74: WARNING:LONG_LINE: line over 80 characters
#74: FILE: drivers/spi/spi_sam0.c:789:
+		.pads = SPI_SAM0_SERCOM_PADS(n)					\

- total: 0 errors, 7 warnings, 91 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Adds a board-specific configuration for the atsame54_xpro to the
spi_loopback test.

Signed-off-by: Benjamin Valentin <[email protected]>
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Nov 7, 2019
@stephanosio stephanosio added this to the v2.2.0 milestone Nov 22, 2019
@stephanosio stephanosio self-requested a review December 11, 2019 13:53
@carlescufi carlescufi merged commit 2d5c6b4 into zephyrproject-rtos:master Dec 18, 2019
@benpicco benpicco deleted the same54-spi branch December 18, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: SPI SPI bus area: Tests Issues related to a particular existing or missing test platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants