Skip to content

Conversation

@benpicco
Copy link
Contributor

It shares the same peripheral with other sam0 parts while differing in the clock config.

split off from #14685

It shares the same peripheral with other sam0 parts while differing
in the clock config.

Signed-off-by: Benjamin Valentin <[email protected]>
@benpicco benpicco added area: I2C platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Oct 23, 2019
@benpicco benpicco requested a review from galak October 23, 2019 10:50
@benpicco benpicco requested a review from Sizurka as a code owner October 23, 2019 10:50
@zephyrbot
Copy link

All checks passed.

checkpatch (informational only, not a failure)

-:17: WARNING:PREFER_KERNEL_TYPES: Prefer kernel type 'u32_t' over 'uint32_t'
#17: FILE: drivers/i2c/i2c_sam0.c:28:
+	volatile uint32_t *mclk;

-:56: WARNING:LONG_LINE: line over 80 characters
#56: FILE: drivers/i2c/i2c_sam0.c:767:
+#define DT_ATMEL_SAM0_I2C_SERCOM_IRQ(n, m) DT_ATMEL_SAM0_I2C_SERCOM_ ## n ## _IRQ_ ## m

-:57: WARNING:LONG_LINE: line over 80 characters
#57: FILE: drivers/i2c/i2c_sam0.c:768:
+#define DT_ATMEL_SAM0_I2C_SERCOM_IRQ_PRIORITY(n, m) DT_ATMEL_SAM0_I2C_SERCOM_ ## n ## _IRQ_ ## m ## _PRIORITY

-:60: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#60: FILE: drivers/i2c/i2c_sam0.c:771:
+	do {								\
+	IRQ_CONNECT(DT_ATMEL_SAM0_I2C_SERCOM_IRQ(n, m),			\

-:87: WARNING:LONG_LINE: line over 80 characters
#87: FILE: drivers/i2c/i2c_sam0.c:798:
+		.regs = (SercomI2cm *)DT_ATMEL_SAM0_I2C_SERCOM_##n##_BASE_ADDRESS, \

- total: 0 errors, 5 warnings, 122 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@stephanosio stephanosio added this to the v2.2.0 milestone Nov 22, 2019
@nashif nashif merged commit a0d6289 into zephyrproject-rtos:master Dec 9, 2019
@benpicco benpicco deleted the same54-i2c branch December 9, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: I2C platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants