Skip to content

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Oct 23, 2019

The RTC peripheral found in the SAMD5x/SAME5x MCUs is very
similar to the one found in existing sam0 devices with only
a few changes to register names and the clock source selection.

split off from #14685

The RTC peripheral found in the SAMD5x/SAME5x MCUs is very
simmilar to the one found in existing sam0 devices with only
a few changes to register names and the clock source selection.

Signed-off-by: Benjamin Valentin <[email protected]>
@benpicco benpicco added area: Timer Timer platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Oct 23, 2019
@benpicco benpicco requested a review from galak October 23, 2019 10:50
@zephyrbot
Copy link

All checks passed.

checkpatch (informational only, not a failure)

-:146: WARNING:LONG_LINE: line over 80 characters
#146: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:9:
+#define MCLK_TC0_MASK ((1 << MCLK_APBAMASK_TC0_Pos) | (1 << MCLK_APBAMASK_TC1_Pos))

-:150: WARNING:LONG_LINE: line over 80 characters
#150: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:13:
+#define MCLK_TC0_MASK ((1 << MCLK_APBBMASK_TC0_Pos) | (1 << MCLK_APBBMASK_TC1_Pos))

-:154: WARNING:LONG_LINE: line over 80 characters
#154: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:17:
+#define MCLK_TC0_MASK ((1 << MCLK_APBCMASK_TC0_Pos) | (1 << MCLK_APBCMASK_TC1_Pos))

-:158: WARNING:LONG_LINE: line over 80 characters
#158: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:21:
+#define MCLK_TC0_MASK ((1 << MCLK_APBDMASK_TC0_Pos) | (1 << MCLK_APBDMASK_TC1_Pos))

-:163: WARNING:LONG_LINE: line over 80 characters
#163: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:26:
+#define MCLK_TC2_MASK ((1 << MCLK_APBAMASK_TC2_Pos) | (1 << MCLK_APBAMASK_TC3_Pos))

-:167: WARNING:LONG_LINE: line over 80 characters
#167: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:30:
+#define MCLK_TC2_MASK ((1 << MCLK_APBBMASK_TC2_Pos) | (1 << MCLK_APBBMASK_TC3_Pos))

-:171: WARNING:LONG_LINE: line over 80 characters
#171: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:34:
+#define MCLK_TC2_MASK ((1 << MCLK_APBCMASK_TC2_Pos) | (1 << MCLK_APBCMASK_TC3_Pos))

-:175: WARNING:LONG_LINE: line over 80 characters
#175: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:38:
+#define MCLK_TC2_MASK ((1 << MCLK_APBDMASK_TC2_Pos) | (1 << MCLK_APBDMASK_TC3_Pos))

-:180: WARNING:LONG_LINE: line over 80 characters
#180: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:43:
+#define MCLK_TC4_MASK ((1 << MCLK_APBAMASK_TC4_Pos) | (1 << MCLK_APBAMASK_TC5_Pos))

-:184: WARNING:LONG_LINE: line over 80 characters
#184: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:47:
+#define MCLK_TC4_MASK ((1 << MCLK_APBBMASK_TC4_Pos) | (1 << MCLK_APBBMASK_TC5_Pos))

-:188: WARNING:LONG_LINE: line over 80 characters
#188: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:51:
+#define MCLK_TC4_MASK ((1 << MCLK_APBCMASK_TC4_Pos) | (1 << MCLK_APBCMASK_TC5_Pos))

-:192: WARNING:LONG_LINE: line over 80 characters
#192: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:55:
+#define MCLK_TC4_MASK ((1 << MCLK_APBDMASK_TC4_Pos) | (1 << MCLK_APBDMASK_TC5_Pos))

-:197: WARNING:LONG_LINE: line over 80 characters
#197: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:60:
+#define MCLK_TC6_MASK ((1 << MCLK_APBAMASK_TC6_Pos) | (1 << MCLK_APBAMASK_TC7_Pos))

-:201: WARNING:LONG_LINE: line over 80 characters
#201: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:64:
+#define MCLK_TC6_MASK ((1 << MCLK_APBBMASK_TC6_Pos) | (1 << MCLK_APBBMASK_TC7_Pos))

-:205: WARNING:LONG_LINE: line over 80 characters
#205: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:68:
+#define MCLK_TC6_MASK ((1 << MCLK_APBCMASK_TC6_Pos) | (1 << MCLK_APBCMASK_TC7_Pos))

-:209: WARNING:LONG_LINE: line over 80 characters
#209: FILE: soc/arm/atmel_sam0/common/tc_fixup_samd5x.h:72:
+#define MCLK_TC6_MASK ((1 << MCLK_APBDMASK_TC6_Pos) | (1 << MCLK_APBDMASK_TC7_Pos))

- total: 0 errors, 16 warnings, 193 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@stephanosio stephanosio added this to the v2.2.0 milestone Nov 22, 2019
@stephanosio stephanosio self-requested a review December 11, 2019 13:53
@nashif nashif merged commit cd08730 into zephyrproject-rtos:master Dec 21, 2019
@benpicco benpicco deleted the same54-timer branch December 21, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Timer Timer platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants