Skip to content

Conversation

@benpicco
Copy link
Contributor

The SAME5x/SAMD5x is a line of Cortex-M4F MCUs that share peripherals with the sam0 Cortex-M0+ and saml1x Cortex-M23 parts.

split off from #14685

@zephyrbot
Copy link

zephyrbot commented Oct 23, 2019

All checks passed.

checkpatch (informational only, not a failure)

-:260: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,sam0-trng" appears un-documented -- check ./dts/bindings/
#260: FILE: dts/arm/atmel/samd5x.dtsi:242:
+			compatible = "atmel,sam0-trng";

-:692: WARNING:LONG_LINE: line over 80 characters
#692: FILE: soc/arm/atmel_sam0/common/soc_samd5x.c:26:
+	OSC32KCTRL->XOSC32K.reg = OSC32KCTRL_XOSC32K_ENABLE | OSC32KCTRL_XOSC32K_XTALEN

-:693: WARNING:LONG_LINE: line over 80 characters
#693: FILE: soc/arm/atmel_sam0/common/soc_samd5x.c:27:
+				| OSC32KCTRL_XOSC32K_EN32K | OSC32KCTRL_XOSC32K_RUNSTDBY

-:724: WARNING:LONG_LINE: line over 80 characters
#724: FILE: soc/arm/atmel_sam0/common/soc_samd5x.c:58:
+	GCLK->PCHCTRL[OSCCTRL_GCLK_ID_FDPLL0 + n].reg = GCLK_PCHCTRL_GEN(1) | GCLK_PCHCTRL_CHEN;

-:725: WARNING:LONG_LINE: line over 80 characters
#725: FILE: soc/arm/atmel_sam0/common/soc_samd5x.c:59:
+	while (!(GCLK->PCHCTRL[OSCCTRL_GCLK_ID_FDPLL0 + n].reg & GCLK_PCHCTRL_CHEN)) {

-:928: WARNING:LONG_LINE: line over 80 characters
#928: FILE: soc/arm/atmel_sam0/samd51/dts_fixup.h:13:
+#define DT_NUM_IRQ_PRIO_BITS	DT_ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS

-:1106: WARNING:LONG_LINE: line over 80 characters
#1106: FILE: soc/arm/atmel_sam0/same51/dts_fixup.h:13:
+#define DT_NUM_IRQ_PRIO_BITS	DT_ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS

-:1276: WARNING:LONG_LINE: line over 80 characters
#1276: FILE: soc/arm/atmel_sam0/same53/dts_fixup.h:13:
+#define DT_NUM_IRQ_PRIO_BITS	DT_ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS

-:1442: WARNING:LONG_LINE: line over 80 characters
#1442: FILE: soc/arm/atmel_sam0/same54/dts_fixup.h:13:
+#define DT_NUM_IRQ_PRIO_BITS	DT_ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS

- total: 0 errors, 9 warnings, 1295 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@benpicco benpicco requested a review from Sizurka October 30, 2019 13:05
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some DT related cleanups but otherwise looks good.

benpicco and others added 6 commits November 6, 2019 21:42
Update hal_atmel to include vendor files for SAMD5x/SAME5x.

Signed-off-by: Benjamin Valentin <[email protected]>
This adds supoprt for the Atmel SAME54 SoC.

The SAME5x/SAMD5x is a line of Cortex-M4F MCUs that share peripherals
with the sam0 Cortex-M0+ and saml1x Cortex-M23 parts.

Signed-off-by: Benjamin Valentin <[email protected]>
The SERCOMS on SAMD5x/SAME5x are connected to different MCLK
APBMASKs. There is no systematic way to tell whether a SERCOM
is connected to APBA, APBB, APBC or APBD, so rely on the
information from ASF instead of replicating it elsewhere.

This is needed for SPI, I2C and UART support on the SAMD5x/SAME5x
platform.

Signed-off-by: Benjamin Valentin <[email protected]>
This adds supoprt for the Atmel SAMD51 SoC.

The SAME5x/SAMD5x is a line of Cortex-M4F MCUs that share peripherals
with the sam0 Cortex-M0+ and saml1x Cortex-M23 parts.

Signed-off-by: Benjamin Valentin <[email protected]>
This adds supoprt for the Atmel SAME51 SoC.

The SAME5x/SAMD5x is a line of Cortex-M4F MCUs that share peripherals
with the sam0 Cortex-M0+ and saml1x Cortex-M23 parts.

Signed-off-by: Benjamin Valentin <[email protected]>
This adds supoprt for the Atmel SAME53 SoC.

The SAME5x/SAMD5x is a line of Cortex-M4F MCUs that share peripherals
with the sam0 Cortex-M0+ and saml1x Cortex-M23 parts.

Signed-off-by: Benjamin Valentin <[email protected]>
@galak galak merged commit 7e72256 into zephyrproject-rtos:master Nov 7, 2019
@benpicco benpicco deleted the same54-initial branch November 7, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree area: Modules platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants