Merge recent changes in master into release branch #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <[email protected]>
* packaging: Add test channels to pytorch dependency resolution Signed-off-by: Eli Uriegas <[email protected]> * .circleci: Add test channel to smoke tests Signed-off-by: Eli Uriegas <[email protected]> * .circleci: Put pytorch-test into a higher priority pytorch-nightly was getting prioritized over pytorch-nightly which shouldn't be the case Signed-off-by: Eli Uriegas <[email protected]>
This is a part of PRs to add new "sox_io" backend. pytorch#726 and depends on pytorch#718 and pytorch#728 . This PR adds `load` function to "sox_io" backend, which is tested on the following audio formats; - `wav` - `mp3` - `flac` - `ogg/vorbis` * By default, "sox_io" backend returns Tensor with `float32` dtype and the shape of `[channel, time]`. The samples are normalized to fit in the range of `[-1.0, 1.0]`. Unlike existing "sox" backend, the new `load` function can handle WAV file natively, when the input format is WAV with integer type, (such as 32-bit signed integer, 16-bit signed integer and 8-bit unsigned integer) by providing `normalize=False`, this function can return integer Tensor, where the samples are expressed within the whole range of the corresponding dtype, that is, `int32` tensor for `32-bit PCM`, `int16` for `16-bit PCM` and `uint8` for `8-bit PCM`. This behavior follows [scipy.io.wavfile.read](https://docs.scipy.org/doc/scipy/reference/generated/scipy.io.wavfile.read.html). `normalize` parameter has no effect for other formats and the load function always return normalized value with `float32` Tensor. __* Note__ The current binary distribution of torchaudio does not contain `ogg/vorbis` and `opus` codecs. To handle these files, one needs to build torchaudio from the source with proper codecs in the system. __Note 2__ Since this PR, `scipy` becomes required module for running test.
* Update functional.py rollback torch.norm() in spectrogram() to v0.4.0. * Update functional.py comment out `spec_f = complex_norm(spec_f, power=power)`. * fixed complex_norm() instead of spectrogram() for torch.norm() issue. * lint Co-authored-by: bongjin.lee <[email protected]> Co-authored-by: Vincent QB <[email protected]>
* update varible names and docstring * update format * update docsting and output value Co-authored-by: Ji Chen <[email protected]>
* Use cmake for third party * Apply patch to libmad * Update gitignore * Update docker test image
This is a part of PRs to add new "sox_io" backend. pytorch#726 and depends on pytorch#718, pytorch#728 and pytorch#731. This PR adds `save` function to "sox_io" backend, which can save Tensor to a file with the following audio formats; - `wav` - `mp3` - `flac` - `ogg/vorbis`
* upsamplenetwork * update name * update name and docstring * update format * rebase * update docstring * update docstring * remove transpose and update docstring Co-authored-by: Ji Chen <[email protected]>
* Pin llvmlite * Add comments
* upsamplenetwork * update variable names * update variable name * add wavernn model * update test * update format * update format * update format * fix conflicts and add transpose * import update * update transpose * update format * update docstring * add n_channel in input * add comment * update docstring * update docstring Co-authored-by: Ji Chen <[email protected]>
…#759) * add Waveforms for Testing Purposes section * Update test/README.md use wrapper function for scipy.io.wavfile.read Co-authored-by: moto <[email protected]> * remove un-used files from the doc * Update test/README.md Rename variable Co-authored-by: moto <[email protected]> * fix indent; remove mentions of unused files * remove whitenoise* files from README.md Co-authored-by: moto <[email protected]>
…ytorch#772) * converted CommonVoice tartar mp3 to wav using rate 8000 Hz * Remove Unused dtmf_30s_stereo.mp3
* Change 'sox' to 'default'
In pytorch#779, we plan to remove `frames_per_chunk` parameter from `save` function, but it will take some time before we can land pytorch#779, so we go ahead and remove the parameter first to reduce the conflict caused by interface change.
Part of pytorch#764 - Replace `whitenoise.wav` with on-the-fly data generation - Replace `torchaudio.load` with `common_utils.load_wav` - Replace `steam-train-whistle-daniel_simon.mp3` with `.wav`
`test/test_sox_effects.py::Test_SoxEffectsChain::test_lowpass_speed` has some issue on our macOS CI, even though there was no issue at pytorch#777 . While we figure out the fix, we disable this test for macOS.
This PR replaces `torchaudio.sox_effects.SoxEffectsChain` in `test_sox_compatibility` with bare `sox` command. The parity of `torchaudio.sox_effects.SoxEffectsChain` against `sox` command is not tested and it has known issues pytorch#771, therefore it is not appropriate to use this class for testing other functions.
This reverts commit fd6e3b4.
Contributor
|
It's probably too late but the following methods would have been simpler
|
Codecov Report
@@ Coverage Diff @@
## release/0.6 #799 +/- ##
==============================================
Coverage ? 89.53%
==============================================
Files ? 32
Lines ? 2617
Branches ? 0
==============================================
Hits ? 2343
Misses ? 274
Partials ? 0 Continue to review full report at Codecov.
|
seemethere
approved these changes
Jul 20, 2020
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge up to db8f2bf from master, which is end of July 14th, see here.