Skip to content

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Jul 13, 2020

In #779, we plan to remove frames_per_chunk parameter from save function, but it will take some time before we can land #779, so we go ahead and remove the parameter first to reduce the conflict caused by interface change.

In pytorch#779, we plan to remove `frames_per_chunk` parameter from `save` function, but it will take some time before we can land pytorch#779, so we go ahead and remove the parameter first to reduce the conflict caused by interface change.
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #780 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
- Coverage   89.53%   89.49%   -0.04%     
==========================================
  Files          32       32              
  Lines        2617     2617              
==========================================
- Hits         2343     2342       -1     
- Misses        274      275       +1     
Impacted Files Coverage Δ
torchaudio/backend/sox_io_backend.py 78.12% <100.00%> (ø)
torchaudio/_internal/module_utils.py 81.48% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9142fd...f051a23. Read the comment docs.

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit 4b3e905 into pytorch:master Jul 14, 2020
@mthrok mthrok deleted the save-interface branch July 14, 2020 16:46
@mthrok
Copy link
Contributor Author

mthrok commented Jul 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants