Add Waveforms for Testing Purposes section to test/README.md #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 32 32
Lines 2617 2617
=======================================
Hits 2343 2343
Misses 274 274 Continue to review full report at Codecov.
|
mthrok
reviewed
Jul 1, 2020
Contributor
|
Thanks for working on this! |
mthrok
reviewed
Jul 2, 2020
mthrok
reviewed
Jul 2, 2020
mthrok
reviewed
Jul 2, 2020
This was referenced Jul 2, 2020
vincentqb
reviewed
Jul 6, 2020
Contributor
|
(rebasing should fix unittest errors) |
use wrapper function for scipy.io.wavfile.read Co-authored-by: moto <[email protected]>
Rename variable Co-authored-by: moto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instructions around generating waveforms in tests from files and on the fly, as well as contributing new assets.