Skip to content

Add opus support to binary distribution #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add opus support to binary distribution #755

merged 1 commit into from
Jul 1, 2020

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Jul 1, 2020 •
edited
Loading

This PR adds OPUS support to binary distribution.

Resolves #688

@mthrok mthrok marked this pull request as draft July 1, 2020 17:28
@codecov
Copy link

codecov bot commented Jul 1, 2020 •
edited
Loading

Codecov Report

Merging #755 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   89.14%   89.14%           
=======================================
  Files          32       32           
  Lines        2561     2561           
=======================================
  Hits         2283     2283           
  Misses        278      278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20da5e...e815688. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review July 1, 2020 18:36
@mthrok mthrok requested review from seemethere and vincentqb July 1, 2020 18:36
@mthrok
Copy link
Contributor Author

mthrok commented Jul 1, 2020

@seemethere I would like to add this to the next release. Let me know what you think.

@mthrok mthrok mentioned this pull request Jul 1, 2020
Merged
6 tasks
vincentqb
vincentqb approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll add it to the release.

@mthrok mthrok merged commit 894959a into pytorch:master Jul 1, 2020
@mthrok
Copy link
Contributor Author

mthrok commented Jul 1, 2020

Thanks

@mthrok mthrok deleted the opus branch July 1, 2020 23:41
mthrok added a commit to mthrok/audio that referenced this pull request Jul 1, 2020
@mthrok
Add opus support (pytorch#755)
88f554b
mthrok added a commit to mthrok/audio that referenced this pull request Jul 2, 2020
@mthrok
Add opus support (pytorch#755)
a5a52c4
This was referenced Jul 2, 2020
Closed
Merged
mthrok added a commit that referenced this pull request Jul 6, 2020
@mthrok
Add OPUS support to 0.6 release (#763)
56aa954 
* Use cmake for third party (#753)

* Use cmake for third party

* Apply patch to libmad

* Update gitignore

* Update docker test image

* Add opus support (#755)
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Merge pull request pytorch#755 from jianyuh/jlin27-quant-tutorials
a33064b 
Update Dynamic Quant BERT Tutorial 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere Awaiting requested review from seemethere

1 more reviewer

@vincentqb vincentqb vincentqb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Opus audio format support

2 participants

@mthrok @vincentqb