Skip to content

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Jul 1, 2020

This PR replaces torchaudio.load_wav with common_utils.load_wav, which is a wrapper around scipy.io.wavfile.read.

This allows each test to not depend on torchaudio's I/O implementation.

@mthrok mthrok force-pushed the replace-test-load branch from 6ca61a8 to 60ae951 Compare July 1, 2020 23:12
@mthrok mthrok force-pushed the replace-test-load branch from 60ae951 to 0ba72b8 Compare July 1, 2020 23:44
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #762 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #762   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files          32       32           
  Lines        2566     2566           
=======================================
  Hits         2288     2288           
  Misses        278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b583ea...0ba72b8. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review July 2, 2020 01:03
@mthrok mthrok requested a review from vincentqb July 2, 2020 01:03
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit e43ee19 into pytorch:master Jul 6, 2020
@mthrok mthrok deleted the replace-test-load branch July 6, 2020 13:49
@mthrok
Copy link
Contributor Author

mthrok commented Jul 6, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants